Skip to content

CCM-14741: Dependency standardisation #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vlasis-Perdikidis merged 9 commits into from
Mar 3, 2026
Merged

CCM-14741: Dependency standardisation #425

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2a76bf3
move dependencies to root where possible
masl2 Feb 24, 2026
9b089ce
remove deprecate eslintignore files
masl2 Feb 26, 2026
8953fa9
Merge branch 'main' into fix/CCM-14741_root-deps
masl2 Feb 27, 2026
51e9d41
resolve minimatch vulnerabilities
Vlasis-Perdikidis Mar 2, 2026
f77a455
resolve the rest of the hight vulnerabilities
Vlasis-Perdikidis Mar 2, 2026
59f1b5c
Merge branch 'main' into fix/CCM-14741_root-deps
Vlasis-Perdikidis Mar 3, 2026
d95907a
npm install
Vlasis-Perdikidis Mar 3, 2026
a5a1eb9
Merge branch 'main' into fix/CCM-14741_root-deps
Vlasis-Perdikidis Mar 3, 2026
285cc4c
npm install
Vlasis-Perdikidis Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"nhsuk-frontend": "^10.1.0"
},
"description": "",
"devDependencies": {},
"engines": {},
"keywords": [],
"license": "ISC",
Expand Down
24 changes: 21 additions & 3 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,31 @@ import {
} from 'eslint-config-airbnb-extended';
import { rules as prettierConfigRules } from 'eslint-config-prettier';

import { dirname } from 'node:path';
import { readFileSync } from 'node:fs';
import { dirname, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
import { FlatCompat } from '@eslint/eslintrc';
import { globSync } from 'glob';

const __filename = fileURLToPath(import.meta.url);
const __dirname = dirname(__filename);

const rootPackageJson = JSON.parse(
readFileSync(new URL('./package.json', import.meta.url), 'utf8'),
);
const workspacePatterns = rootPackageJson.workspaces ?? [];
const workspacePackageDirs = workspacePatterns.flatMap((pattern) =>
globSync(`${pattern}/package.json`, {
cwd: __dirname,
ignore: ['**/node_modules/**'],
}).map((packageJsonPath) =>
resolve(__dirname, packageJsonPath.replace(/\/package\.json$/, '')),
),
);
const monorepoPackageDirs = Array.from(
new Set([__dirname, ...workspacePackageDirs]),
);

const compat = new FlatCompat({
baseDirectory: __dirname,
});
Expand Down Expand Up @@ -171,7 +189,7 @@ export default defineConfig([
rules: {
'import-x/no-extraneous-dependencies': [
2,
{ devDependencies: true },
{ devDependencies: true, packageDir: monorepoPackageDirs },
],
},
},
Expand All @@ -188,7 +206,7 @@ export default defineConfig([
rules: {
'import-x/no-extraneous-dependencies': [
'error',
{ devDependencies: true },
{ devDependencies: true, packageDir: monorepoPackageDirs },
],
},
},
Expand Down
1 change: 0 additions & 1 deletion internal/datastore/.eslintignore
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions internal/datastore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,6 @@
"zod": "^4.1.11",
"zod-mermaid": "^1.0.9"
},
"devDependencies": {
"@stylistic/eslint-plugin": "^5.8.0",
"@tsconfig/node22": "^22.0.2",
"@types/jest": "^30.0.0",
"@typescript-eslint/eslint-plugin": "^8.46.2",
"@typescript-eslint/parser": "^8.27.0",
"eslint": "^9.27.0",
"eslint-plugin-jest": "^29.0.1",
"jest": "^30.2.0",
"jest-mock-extended": "^4.0.0",
"testcontainers": "^11.4.0",
"ts-jest": "^29.4.0",
"ts-node": "^10.9.2",
"typescript": "^5.9.3"
},
"license": "MIT",
"main": "src/index.ts",
"name": "@internal/datastore",
Expand Down
16 changes: 1 addition & 15 deletions internal/events/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,6 @@
"zod": "^4.1.11"
},
"description": "Schemas for NHS Notify Supplier API events",
"devDependencies": {
"@stoplight/spectral-cli": "^6.15.0",
"@stylistic/eslint-plugin": "^5.8.0",
"@tsconfig/node22": "^22.0.2",
"@types/jest": "^30.0.0",
"@typescript-eslint/eslint-plugin": "^8.27.0",
"@typescript-eslint/parser": "^8.27.0",
"eslint": "^9.27.0",
"eslint-plugin-jest": "^29.0.1",
"jest": "^30.2.0",
"ts-jest": "^29.4.0",
"ts-node": "^10.9.2",
"typescript": "^5.9.3"
},
"license": "MIT",
"main": "dist/index.js",
"name": "@nhsdigital/nhs-notify-event-schemas-supplier-api",
Expand Down Expand Up @@ -51,5 +37,5 @@
"typecheck": "tsc --noEmit"
},
"types": "dist/index.d.ts",
"version": "1.0.12"
"version": "1.0.13"
}
13 changes: 0 additions & 13 deletions internal/helpers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,6 @@
"zod": "^4.1.11"
},
"description": "Common helper utilities for NHS Notify Supplier API",
"devDependencies": {
"@stylistic/eslint-plugin": "^5.8.0",
"@tsconfig/node22": "^22.0.2",
"@types/jest": "^30.0.0",
"@typescript-eslint/eslint-plugin": "^8.27.0",
"@typescript-eslint/parser": "^8.27.0",
"eslint": "^9.27.0",
"eslint-plugin-jest": "^29.0.1",
"jest": "^30.2.0",
"ts-jest": "^29.4.0",
"ts-node": "^10.9.2",
"typescript": "^5.9.3"
},
"license": "MIT",
"main": "src/index.ts",
"name": "@internal/helpers",
Expand Down
1 change: 0 additions & 1 deletion lambdas/api-handler/.eslintignore
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions lambdas/api-handler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,6 @@
"pino": "^10.3.0",
"zod": "^4.1.11"
},
"devDependencies": {
"@tsconfig/node22": "^22.0.2",
"@types/aws-lambda": "^8.10.148",
"@types/jest": "^30.0.0",
"jest": "^30.2.0",
"jest-mock-extended": "^4.0.0",
"ts-jest": "^29.4.0",
"typescript": "^5.9.3",
"zod": "^4.1.11"
},
"name": "nhs-notify-supplier-api-handler",
"private": true,
"scripts": {
Expand Down
1 change: 0 additions & 1 deletion lambdas/authorizer/.eslintignore
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions lambdas/authorizer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,6 @@
"pino": "^10.3.0",
"zod": "^4.1.11"
},
"devDependencies": {
"@tsconfig/node22": "^22.0.2",
"@types/aws-lambda": "^8.10.148",
"@types/jest": "^30.0.0",
"jest": "^30.2.0",
"jest-mock-extended": "^4.0.0",
"ts-jest": "^29.4.0",
"typescript": "^5.9.3"
},
"name": "nhs-notify-supplier-authorizer",
"private": true,
"scripts": {
Expand Down
1 change: 0 additions & 1 deletion lambdas/letter-updates-transformer/.eslintignore
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions lambdas/letter-updates-transformer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,6 @@
"pino": "^10.3.0",
"zod": "^4.1.13"
},
"devDependencies": {
"@tsconfig/node22": "^22.0.2",
"@types/aws-lambda": "^8.10.148",
"@types/jest": "^30.0.0",
"jest": "^30.2.0",
"jest-mock-extended": "^4.0.0",
"ts-jest": "^29.4.0",
"typescript": "^5.8.3"
},
"name": "nhs-notify-supplier-api-letter-updates-transformer",
"private": true,
"scripts": {
Expand Down
8 changes: 0 additions & 8 deletions lambdas/mi-updates-transformer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,6 @@
"pino": "^10.3.0",
"zod": "^4.1.13"
},
"devDependencies": {
"@tsconfig/node22": "^22.0.2",
"@types/aws-lambda": "^8.10.148",
"@types/jest": "^30.0.0",
"jest": "^30.2.0",
"jest-mock-extended": "^4.0.0",
"typescript": "^5.8.3"
},
"name": "nhs-notify-supplier-api-mi-updates-transformer",
"private": true,
"scripts": {
Expand Down
1 change: 0 additions & 1 deletion lambdas/supplier-allocator/.eslintignore
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions lambdas/supplier-allocator/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,6 @@
"pino": "^9.7.0",
"zod": "^4.1.11"
},
"devDependencies": {
"@tsconfig/node22": "^22.0.2",
"@types/aws-lambda": "^8.10.148",
"@types/jest": "^30.0.0",
"jest": "^30.2.0",
"jest-mock-extended": "^4.0.0",
"ts-jest": "^29.4.0",
"typescript": "^5.8.3"
},
"name": "nhs-notify-supplier-api-allocate-letter",
"private": true,
"scripts": {
Expand Down
1 change: 0 additions & 1 deletion lambdas/upsert-letter/.eslintignore
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions lambdas/upsert-letter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,6 @@
"pino": "^10.3.0",
"zod": "^4.1.11"
},
"devDependencies": {
"@tsconfig/node22": "^22.0.2",
"@types/aws-lambda": "^8.10.148",
"@types/jest": "^30.0.0",
"jest": "^30.2.0",
"jest-mock-extended": "^4.0.0",
"ts-jest": "^29.4.0",
"typescript": "^5.8.3"
},
"name": "nhs-notify-supplier-api-upsert-letter",
"private": true,
"scripts": {
Expand Down
Loading
Loading