Skip replayed letter event#495
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to make the upsert-letter flow idempotent by treating replayed “insert” events (where the letter already exists) as non-failures, and updating tests/utilities accordingly.
Changes:
- Introduce and propagate a
LetterAlreadyExistsErrorfrom the datastore, and handle it in the upsert-letter Lambda by logging a warning instead of failing the batch item. - Refactor CloudWatch polling test helpers and update component tests to look for a warning (rather than an error) for duplicate/replayed events.
- Update event schema dependency version in
package-lock.json.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/helpers/aws-cloudwatch-helper.ts | Refactors log polling into a generic helper and adds warning polling for upsert-letter logs. |
| tests/constants/api-constants.ts | Alters how the test environment name is determined for AWS resource naming. |
| tests/component-tests/letterQueue-tests/queue-operations.spec.ts | Updates duplicate insert assertion to poll for a warning log. |
| tests/component-tests/events-tests/event-subscription.spec.ts | Updates duplicate event assertion to poll for a warning log. |
| package-lock.json | Bumps @nhsdigital/nhs-notify-event-schemas-supplier-api version. |
| lambdas/upsert-letter/src/handler/upsert-handler.ts | Catches LetterAlreadyExistsError and logs a warning instead of failing. |
| lambdas/upsert-letter/src/handler/tests/upsert-handler.test.ts | Adds unit test ensuring replayed insert does not create batch failures; updates logger mock to include warn. |
| lambdas/upsert-letter/jest.config.ts | Adds transformIgnorePatterns exception for event schema package(s). |
| internal/datastore/src/letter-repository.ts | Throws LetterAlreadyExistsError on conditional put conflict. |
| internal/datastore/src/test/letter-repository.test.ts | Updates expectation to assert LetterAlreadyExistsError is thrown. |
nhsd-david-wass
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.