Skip to content

CCM-15589: Fix Tests #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Namitha-Prabhu merged 3 commits into from
Apr 20, 2026
Merged

CCM-15589: Fix Tests #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4830425
fix
Namitha-Prabhu Apr 20, 2026
30672a2
add commit to gitleaksignore
Vlasis-Perdikidis Apr 16, 2026
b8be2e9
add dependencies
Namitha-Prabhu Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .gitleaksignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,9 @@ debc75a97cfe551a69fd1e8694be483213322a9d:pact-contracts/pacts/letter-rendering/s
4fa1923947bbff2387218d698d766cbb7c121a0f:pact-contracts/pacts/letter-rendering/supplier-api-letter-request-prepared.json:generic-api-key:10
d005112adcfd286c3bef076214836dbb2fe8d0b5:.npmrc:npm-access-token:9
d005112adcfd286c3bef076214836dbb2fe8d0b5:.npmrc:github-pat:7
ff889d4c3f29da4468ecf1f05f467fe84d35b2a1:lambdas/supplier-mock/.aws-sam/build/SupplierMockFunction/index.js.map:ipv4:4
ff889d4c3f29da4468ecf1f05f467fe84d35b2a1:lambdas/supplier-mock/.aws-sam/build/SupplierMockFunction/index.js:ipv4:63
ff889d4c3f29da4468ecf1f05f467fe84d35b2a1:lambdas/supplier-mock/.aws-sam/build/SupplierMockFunction/index.js:ipv4:62
ff889d4c3f29da4468ecf1f05f467fe84d35b2a1:lambdas/supplier-mock/.aws-sam/build/SupplierMockFunction/index.js:ipv4:60
ff889d4c3f29da4468ecf1f05f467fe84d35b2a1:lambdas/supplier-mock/.aws-sam/build/SupplierMockFunction/index.js:ipv4:59
ff889d4c3f29da4468ecf1f05f467fe84d35b2a1:lambdas/supplier-mock/.aws-sam/build/SupplierMockFunction/index.js:ipv4:24
1 change: 1 addition & 0 deletions tests/component-tests/integration-tests/urgent-letter-priority.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ test.describe("Urgent Letter Priority Tests", () => {
await verifyAllocationLogsContainPriority(urgencyTenLetterIds, 10);

const lettersFromQueue = await getLettersFromQueueViaIndex(supplier);

const letterIdsFromQueue = lettersFromQueue.map(
(letter) => letter.letterId,
);
Expand Down
2 changes: 2 additions & 0 deletions tests/config/main.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const localConfig: PlaywrightTestConfig = {
name: "apiGateway-tests",
testDir: path.resolve(__dirname, "../component-tests/apiGateway-tests"),
testMatch: "**/*.spec.ts",
dependencies: ["integration-tests"],
},
{
name: "events-tests",
Expand All @@ -24,6 +25,7 @@ const localConfig: PlaywrightTestConfig = {
name: "letterQueue-tests",
testDir: path.resolve(__dirname, "../component-tests/letterQueue-tests"),
testMatch: "**/*.spec.ts",
dependencies: ["apiGateway-tests"],
},
{
name: "integration-tests",
Expand Down
6 changes: 6 additions & 0 deletions tests/helpers/urgent-letter-priority-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ export function verifyIndexPositionOfLetterVariants(

// All higher-urgency letters must appear before any lower-urgency letter
expect(highestUrgencyMaxIndex).toBeLessThan(lowerUrgencyMinIndex);
logger.info(
`Verified all higher urgency letters appear before lower urgency letters in index. Highest index for urgency ${variantUrgencyMap[letterIdsHigherUrgency[0]]} was ${highestUrgencyMaxIndex}, lowest index for urgency ${variantUrgencyMap[letterIdsLowerUrgency[0]]} was ${lowerUrgencyMinIndex}`,
);
}

export async function verifyAllocationLogsContainPriority(
Expand All @@ -111,5 +114,8 @@ export async function verifyAllocationLogsContainPriority(
expect(supplierSpec).toBeDefined();
expect(supplierSpec.priority).toBeDefined();
expect(supplierSpec.priority).toBe(priority);
logger.info(
`Verified log for domainId ${domainId} contains priority ${priority}`,
);
}
}
Loading