Skip to content

CCM-12392: Allocation idempotency#574

Merged
nhsd-david-wass merged 2 commits into
mainfrom
feature/CCM-12392-Letter-Event-Idempotency
Jun 18, 2026
Merged

CCM-12392: Allocation idempotency#574
nhsd-david-wass merged 2 commits into
mainfrom
feature/CCM-12392-Letter-Event-Idempotency

Conversation

@nhsd-david-wass

Copy link
Copy Markdown
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

DT3-Specific Checklist

  • If I have added a new resource (SQS, Lambda, Gateway, DDB table, etc), I have created the appropriate alarms

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhsd-david-wass nhsd-david-wass requested review from a team as code owners May 12, 2026 10:23
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-12392-Letter-Event-Idempotency branch 11 times, most recently from dfbf624 to e1cfaab Compare May 19, 2026 09:47
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-12392-Letter-Event-Idempotency branch 2 times, most recently from 54ba53d to 2a6c9b6 Compare May 20, 2026 08:35
Comment thread tests/helpers/send-sqs-event.ts Fixed
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-12392-Letter-Event-Idempotency branch 4 times, most recently from 7a90a03 to d938b0a Compare May 21, 2026 07:34
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-12392-Letter-Event-Idempotency branch 2 times, most recently from 47a2ce5 to 40b7347 Compare June 1, 2026 14:22
Comment thread tests/component-tests/allocation-tests/supplier-allocation.spec.ts Outdated
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-12392-Letter-Event-Idempotency branch from 40b7347 to 35d8a5e Compare June 3, 2026 08:27

@stevebux stevebux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, a few suggested changes

Comment thread lambdas/supplier-allocator/src/handler/allocate-handler.ts Outdated
Comment thread lambdas/supplier-allocator/src/handler/allocate-handler.ts Outdated
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-12392-Letter-Event-Idempotency branch from 7486aec to d08117d Compare June 4, 2026 12:34
Comment thread tests/config/main.config.ts
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-12392-Letter-Event-Idempotency branch 3 times, most recently from f9f905f to 9aeeade Compare June 16, 2026 14:07
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-12392-Letter-Event-Idempotency branch from 9aeeade to 920d8dd Compare June 18, 2026 09:19
@sonarqubecloud

Copy link
Copy Markdown

@nhsd-david-wass nhsd-david-wass merged commit 2259848 into main Jun 18, 2026
70 of 71 checks passed
@nhsd-david-wass nhsd-david-wass deleted the feature/CCM-12392-Letter-Event-Idempotency branch June 18, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants