Skip to content

CCM-18535: new proxygen mtls namespace#597

Merged
francisco-videira-nhs merged 5 commits into
mainfrom
feature/CCM-18535
May 29, 2026
Merged

CCM-18535: new proxygen mtls namespace#597
francisco-videira-nhs merged 5 commits into
mainfrom
feature/CCM-18535

Conversation

@francisco-videira-nhs

Copy link
Copy Markdown
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

DT3-Specific Checklist

  • If I have added a new resource (SQS, Lambda, Gateway, DDB table, etc), I have created the appropriate alarms

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@francisco-videira-nhs francisco-videira-nhs requested review from a team as code owners May 28, 2026 15:22
@francisco-videira-nhs francisco-videira-nhs changed the title CCM-18535: new mtls namespace CCM-18535: new proxygen mtls namespace May 28, 2026
Comment thread .github/actions/build-proxies/action.yml
@francisco-videira-nhs francisco-videira-nhs added the deploy-proxy Set to 'true' to force a PR build to deploy the APIM proxy label May 28, 2026
masl2
masl2 previously approved these changes May 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the mTLS secret references for the Proxygen deployments to use the consistent nhs-notify-supplier-* namespace per environment, and removes a now-redundant block from the build-proxies GitHub Action that previously set INSTANCE, TARGET, SANDBOX_TAG, and MTLS_NAME env vars (this logic has moved to the internal proxy-deploy workflow).

Changes:

  • Updates mTLS secret names in ref, int, internal-dev, and internal-dev-pr target specs to the new namespaced convention.
  • Uses a prNNN placeholder in the internal-dev-pr target that is dynamically replaced by the internal proxy-deploy workflow.
  • Removes the per-PR / non-PR setup block (INSTANCE, TARGET, SANDBOX_TAG, MTLS_NAME) from .github/actions/build-proxies/action.yml.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
specification/api/components/environments/ref/target.yml Renames mTLS secret to nhs-notify-supplier-mtls-ref.
specification/api/components/environments/int/target.yml Renames mTLS secret to nhs-notify-supplier-mtls-int.
specification/api/components/environments/internal-dev/target.yml Renames mTLS secret to nhs-notify-supplier-mtls-internal-dev.
specification/api/components/environments/internal-dev-pr/target.yml Uses prNNN placeholder, replaced at deploy time by the internal proxy-deploy workflow.
.github/actions/build-proxies/action.yml Removes obsolete PR/non-PR env-var block now handled by the internal repo workflow.

masl2
masl2 previously approved these changes May 29, 2026
RossFaulds171
RossFaulds171 previously approved these changes May 29, 2026
@francisco-videira-nhs francisco-videira-nhs dismissed stale reviews from RossFaulds171 and masl2 via d1d258a May 29, 2026 15:09
@francisco-videira-nhs francisco-videira-nhs merged commit 7d7fdd2 into main May 29, 2026
40 checks passed
@francisco-videira-nhs francisco-videira-nhs deleted the feature/CCM-18535 branch May 29, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy-proxy Set to 'true' to force a PR build to deploy the APIM proxy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants