CCM-18535: new proxygen mtls namespace#597
Merged
Merged
Conversation
masl2
previously approved these changes
May 28, 2026
There was a problem hiding this comment.
Pull request overview
Renames the mTLS secret references for the Proxygen deployments to use the consistent nhs-notify-supplier-* namespace per environment, and removes a now-redundant block from the build-proxies GitHub Action that previously set INSTANCE, TARGET, SANDBOX_TAG, and MTLS_NAME env vars (this logic has moved to the internal proxy-deploy workflow).
Changes:
- Updates mTLS secret names in
ref,int,internal-dev, andinternal-dev-prtarget specs to the new namespaced convention. - Uses a
prNNNplaceholder in theinternal-dev-prtarget that is dynamically replaced by the internal proxy-deploy workflow. - Removes the per-PR / non-PR setup block (INSTANCE, TARGET, SANDBOX_TAG, MTLS_NAME) from
.github/actions/build-proxies/action.yml.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| specification/api/components/environments/ref/target.yml | Renames mTLS secret to nhs-notify-supplier-mtls-ref. |
| specification/api/components/environments/int/target.yml | Renames mTLS secret to nhs-notify-supplier-mtls-int. |
| specification/api/components/environments/internal-dev/target.yml | Renames mTLS secret to nhs-notify-supplier-mtls-internal-dev. |
| specification/api/components/environments/internal-dev-pr/target.yml | Uses prNNN placeholder, replaced at deploy time by the internal proxy-deploy workflow. |
| .github/actions/build-proxies/action.yml | Removes obsolete PR/non-PR env-var block now handled by the internal repo workflow. |
masl2
previously approved these changes
May 29, 2026
RossFaulds171
previously approved these changes
May 29, 2026
d1d258a
masl2
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
DT3-Specific Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.