Skip to content

CCM-18535: new proxygen mtls namespace #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francisco-videira-nhs merged 5 commits into from
May 29, 2026
Merged

CCM-18535: new proxygen mtls namespace #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f18672
new mtls namespace
francisco-videira-nhs May 28, 2026
e881948
mtls pr secret comment
francisco-videira-nhs May 28, 2026
2bdf5f1
temp internal ref
francisco-videira-nhs May 29, 2026
c41a4a2
disable sandbox tests
francisco-videira-nhs May 29, 2026
d1d258a
remove internal ref
francisco-videira-nhs May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .github/actions/build-proxies/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,19 +72,6 @@ runs:
echo "TARGET_DOMAIN=suppliers.dev.nhsnotify.national.nhs.uk" >> $GITHUB_ENV
fi

if [ -z $PR_NUMBER ]
then
echo "INSTANCE=$PROXYGEN_API_NAME" >> $GITHUB_ENV
echo "TARGET=https://main.$TARGET_DOMAIN" >> $GITHUB_ENV
echo "SANDBOX_TAG=latest" >> $GITHUB_ENV
echo "MTLS_NAME=notify-supplier-mtls" >> $GITHUB_ENV
else
echo "TARGET=https://pr$PR_NUMBER.$TARGET_DOMAIN" >> $GITHUB_ENV
echo "INSTANCE=$PROXYGEN_API_NAME-PR-$PR_NUMBER" >> $GITHUB_ENV
echo "SANDBOX_TAG=pr$PR_NUMBER" >> $GITHUB_ENV
echo "MTLS_NAME=notify-supplier-mtls-pr$PR_NUMBER" >> $GITHUB_ENV
fi
Comment thread
masl2 marked this conversation as resolved.

- name: Set APIM_ENV
shell: bash
run: |
Expand Down
3 changes: 1 addition & 2 deletions .github/actions/test-types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
[
"component",
"e2e",
"sandbox"
"e2e"
]
2 changes: 1 addition & 1 deletion specification/api/components/environments/int/target.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ healthcheck: /_status
url: https://main.suppliers.nonprod.nhsnotify.national.nhs.uk
security:
type: mtls
secret: notify-supplier-mtls-int
secret: nhs-notify-supplier-mtls-int
2 changes: 1 addition & 1 deletion specification/api/components/environments/internal-dev-pr/target.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ healthcheck: /_status
url: https://suppliers.dev.nhsnotify.national.nhs.uk
security:
type: mtls
secret: nhs-notify-supplier-mtls
secret: nhs-notify-supplier-mtls-internal-dev-prNNN # Will be dynamically set via the proxy-deploy workflow in the internal repo
2 changes: 1 addition & 1 deletion specification/api/components/environments/internal-dev/target.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ healthcheck: /_status
url: https://suppliers.dev.nhsnotify.national.nhs.uk
security:
type: mtls
secret: nhs-notify-supplier-mtls
secret: nhs-notify-supplier-mtls-internal-dev
2 changes: 1 addition & 1 deletion specification/api/components/environments/ref/target.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ healthcheck: /_status
url: https://main.suppliers.nonprod.nhsnotify.national.nhs.uk
security:
type: mtls
secret: notify-supplier-mtls-ref
secret: nhs-notify-supplier-mtls-ref
Loading