Clean up CLI tool output

Author: m-houston

packages/excel-parser/src/cli-parse.ts

@@ -55,11 +55,7 @@ async function writeParseOutput(args: {
     console.error(
       `✓ Successfully parsed and wrote file-store output to: ${resolvedOutputDir}`,
     );
-
-    return;
-  }
-
-  if (output) {
+  } else if (output) {
     const resolvedOutput = resolveCliPath(output);
 
     // eslint-disable-next-line security/detect-non-literal-fs-filename
@@ -68,12 +64,7 @@ async function writeParseOutput(args: {
     console.error(
       `✓ Successfully parsed and wrote output to: ${resolvedOutput}`,
     );
-
-    return;
   }
-
-  // eslint-disable-next-line no-console
-  console.log(jsonOutput);
 }
 
 function reportMappingValidation(
@@ -117,7 +108,7 @@ async function parseArguments(): Promise<Arguments> {
     .option("output", {
       alias: "o",
       type: "string",
-      description: "Write output to a file instead of stdout",
+      description: "Write output to a file",
     })
     .option("output-dir", {
       alias: "d",
@@ -168,22 +159,24 @@ async function runParser({
   assertValidInputFile(resolvedInput);
 
   const result = parseExcelFile(resolvedInput);
-  const mappingValidation = checkMappings
-    ? validateIncompleteMappings(result)
-    : undefined;
   const jsonOutput = stringifyJsonWithSortedKeys(
     result,
     pretty ? 2 : undefined,
   );
 
-  await writeParseOutput({
-    jsonOutput,
-    output,
-    outputDir,
-    pretty,
-    result,
-  });
-  reportMappingValidation(mappingValidation);
+  if (output || outputDir) {
+    await writeParseOutput({
+      jsonOutput,
+      output,
+      outputDir,
+      pretty,
+      result,
+    });
+  }
+
+  if (checkMappings) {
+    reportMappingValidation(validateIncompleteMappings(result));
+  }
 }
 
 async function main(): Promise<void> {