Skip to content

ENG-1371 allow framework to be toggles - #131

Open
susana-zhou1 wants to merge 2 commits into
mainfrom
ENG-1371-toggle-framework-resources-separately
Open

ENG-1371 allow framework to be toggles#131
susana-zhou1 wants to merge 2 commits into
mainfrom
ENG-1371-toggle-framework-resources-separately

Conversation

@susana-zhou1

@susana-zhou1 susana-zhou1 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

This PR introduces per-plan framework toggles and aligns tag-selection behavior for Aurora and restore testing.

Changes included:

  • Added a new optional create_framework flag (default true) to backup plan config objects so framework creation can be enabled/disabled independently per plan.
  • Updated all aws_backup_framework resources to require both enable and create_framework.
  • Updated framework ARN aggregation logic to use the same enable && create_framework guards, avoiding invalid index access when frameworks are disabled.
  • Added Aurora null-checked local tag/value handling to match other plan configs.
  • Updated Aurora backup selection to respect selection_tag_value and selection_tags.
  • Updated restore testing selections (DynamoDB, EBS, Aurora) to build string_equals from local null-checked selection tag lists rather than hardcoded "True".

Context

This change is required to allow teams to disable AWS Backup Framework resources without disabling backup plans themselves.

It also resolves inconsistencies where:

  • backup selections and restore-testing selections could use different tag-value behavior,
  • Aurora config lacked parity with other plan configs for selection_tag_value and selection_tags.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant