Standardize batch correction figure behavior across function calls#4
Open
phoman14 wants to merge 10 commits into
Open
Standardize batch correction figure behavior across function calls#4phoman14 wants to merge 10 commits into
phoman14 wants to merge 10 commits into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
CCBR/MOSuitefrom theFigOutSyncbranch during setup and sync the vendoredcode/MOSuitepackage to the same updatedbatch_correct_counts()figure behavior before the next released image/package update./code/MOSuitepackage at runtime withdevtools::load_all('/code/MOSuite'), matching capsules where the package code is available incode/MOSuite.batch_correct_counts()supports them.FigOutSyncpackage install, updated CLI arguments, and app panel parameters.@phoman14attribution to the development changelog entries for this PR.Issues
No linked issue.
PR Checklist
CHANGELOG.mdwith a short description of any user-facing changes and reference the PR number. Follow the style described in https://style.tidyverse.org/news.htmltestsworkflow succeeds on the latest commit.Validation:
Rscript tests/testthat.R(PASS 30)Rscript -e 'jsonlite::fromJSON(".codeocean/app-panel.json")'git diff --check