Skip to content

fix: Number component incorrectly uses label as validator key #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nie7321 merged 1 commit into from
Apr 16, 2026
Merged

fix: Number component incorrectly uses label as validator key #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Components/Inputs/Number.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,21 @@ class Number extends BaseComponent

protected function processValidations(string $fieldKey, string $fieldLabel, mixed $submissionValue, Factory $validator): MessageBag
{
$fieldKey = $this->label() ?? $this->key();

$rules = new RuleBag($fieldKey, ['numeric']);
$rules->addIf('required', $this->validation('required') === true);

$this->validation('required')
? $rules->add('required')
: $rules->add('nullable');

$rules->addIfNotNull(sprintf('min:%s', $this->validation('min')), $this->validation('min'));
$rules->addIfNotNull(sprintf('max:%s', $this->validation('max')), $this->validation('max'));

$validator = app()->make('validator')->make(
return $validator->make(
[$fieldKey => $submissionValue],
$rules->rules(),
[],
[$fieldKey => $fieldLabel]
);

return $validator->messages();
)->messages();
}

/**
Expand Down
5 changes: 4 additions & 1 deletion tests/Components/Inputs/NumberTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ public static function validationsProvider(): array
'min passes' => [['min' => 10], 11, true],
'max fails' => [['max' => 3], 4, false],
'max passes' => [['max' => 3], 3, true],
];
// Regression: optional number field should accept null without error
'optional empty passes' => [[], null, true],
'optional empty string passes' => [[], '', true],
];
}

public static function submissionValueProvider(): array
Expand Down
Loading