Fixed offset by one in ActivityTraceProperty.DurationMs (#57)

snakefoot · web-flow · commit 6a66c817930c · 2022-07-29T20:21:31.000+02:00
diff --git a/src/NLog.DiagnosticSource/LayoutRenderers/ActivityTraceLayoutRenderer.cs b/src/NLog.DiagnosticSource/LayoutRenderers/ActivityTraceLayoutRenderer.cs
@@ -131,7 +131,7 @@ private void RenderDurationMs(StringBuilder builder, System.Diagnostics.Activity
                 if (ReferenceEquals(Culture, System.Globalization.CultureInfo.InvariantCulture) && string.IsNullOrEmpty(Format))
                 {
                     var truncateMs = (long)durationMs.Value;
-                    if (DurationMsFormat != null && truncateMs >= 0 && truncateMs <= DurationMsFormat.Length)
+                    if (DurationMsFormat != null && truncateMs >= 0 && truncateMs < DurationMsFormat.Length)
                     {
                         builder.Append(DurationMsFormat[truncateMs]);
                     }
@@ -148,7 +148,7 @@ private void RenderDurationMs(StringBuilder builder, System.Diagnostics.Activity
                         if (preciseMs < 10)
                             builder.Append('0');
 
-                        if (DurationMsFormat != null && preciseMs <= DurationMsFormat.Length)
+                        if (DurationMsFormat != null && preciseMs < DurationMsFormat.Length)
                         {
                             builder.Append(DurationMsFormat[preciseMs]);
                         }

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ private void RenderDurationMs(StringBuilder builder, System.Diagnostics.Activity`
`131`	`131`	`if (ReferenceEquals(Culture, System.Globalization.CultureInfo.InvariantCulture) && string.IsNullOrEmpty(Format))`
`132`	`132`	`{`
`133`	`133`	`var truncateMs = (long)durationMs.Value;`
`134`		`- if (DurationMsFormat != null && truncateMs >= 0 && truncateMs <= DurationMsFormat.Length)`
	`134`	`+ if (DurationMsFormat != null && truncateMs >= 0 && truncateMs < DurationMsFormat.Length)`
`135`	`135`	`{`
`136`	`136`	`builder.Append(DurationMsFormat[truncateMs]);`
`137`	`137`	`}`
`@@ -148,7 +148,7 @@ private void RenderDurationMs(StringBuilder builder, System.Diagnostics.Activity`
`148`	`148`	`if (preciseMs < 10)`
`149`	`149`	`builder.Append('0');`
`150`	`150`
`151`		`- if (DurationMsFormat != null && preciseMs <= DurationMsFormat.Length)`
	`151`	`+ if (DurationMsFormat != null && preciseMs < DurationMsFormat.Length)`
`152`	`152`	`{`
`153`	`153`	`builder.Append(DurationMsFormat[preciseMs]);`
`154`	`154`	`}`