NLogLogger refactoring to reduce code-path-navigations (#539)

* Fixed various issues reported by EnableNETAnalyzers

Author: snakefoot

src/NLog.Extensions.Logging/Extensions/ConfigureExtensions.cs

@@ -228,7 +228,7 @@ public static NLogLoggerProvider Configure(this NLogLoggerProvider nlogProvider,
                 {
                     try
                     {
-                        var result = Convert.ChangeType(configValue.Value, propertyInfo.PropertyType);
+                        var result = Convert.ChangeType(configValue.Value, propertyInfo.PropertyType, System.Globalization.CultureInfo.InvariantCulture);
                         propertyInfo.SetMethod.Invoke(nlogProvider.Options, new[] { result });
                     }
                     catch (Exception ex)

src/NLog.Extensions.Logging/LayoutRenderers/MicrosoftConsoleLayoutRenderer.cs

@@ -12,7 +12,7 @@ namespace NLog.Extensions.Logging
     [ThreadAgnostic]
     class MicrosoftConsoleLayoutRenderer : LayoutRenderer
     {
-        private static readonly string[] EventIdMapper = Enumerable.Range(0, 50).Select(id => id.ToString()).ToArray();
+        private static readonly string[] EventIdMapper = Enumerable.Range(0, 50).Select(id => id.ToString(System.Globalization.CultureInfo.InvariantCulture)).ToArray();
 
         /// <inheritdoc />
         protected override void Append(StringBuilder builder, LogEventInfo logEvent)
@@ -21,7 +21,7 @@ protected override void Append(StringBuilder builder, LogEventInfo logEvent)
             builder.Append(microsoftLogLevel);
             builder.Append(": ");
             builder.Append(logEvent.LoggerName);
-            builder.Append("[");
+            builder.Append('[');
             int eventId = 0;
             if (logEvent.HasProperties && logEvent.Properties.TryGetValue("EventId_Id", out var eventIdValue))
             {
@@ -35,7 +35,7 @@ protected override void Append(StringBuilder builder, LogEventInfo logEvent)
                 eventId = 0;
             }
             builder.Append(ConvertEventId(eventId));
-            builder.Append("]");
+            builder.Append(']');
             builder.Append(System.Environment.NewLine);
             builder.Append("      ");
             builder.Append(logEvent.FormattedMessage);
@@ -53,7 +53,7 @@ static string ConvertEventId(int eventId)
             else if (eventId > 0 || eventId < EventIdMapper.Length)
                 return EventIdMapper[eventId];
             else
-                return eventId.ToString();
+                return eventId.ToString(System.Globalization.CultureInfo.InvariantCulture);
         }
 
         string ConvertLogLevel(LogLevel logLevel)