Skip to content

Commit f34f23c

Browse files
Merge pull request #185 from snakefoot/master
Removed System.Runtime for net451
2 parents cf8d8b6 + 4b322be commit f34f23c

2 files changed

Lines changed: 19 additions & 17 deletions

File tree

src/NLog.Extensions.Logging/NLog.Extensions.Logging.csproj

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,18 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3+
<RestoreProjectStyle>PackageReference</RestoreProjectStyle>
4+
5+
<TargetFrameworks>net451;net461;netstandard1.5;netstandard2.0</TargetFrameworks>
6+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
7+
<GenerateDocumentationFile>true</GenerateDocumentationFile>
8+
39
<Description>NLog provider for Microsoft.Extensions.Logging for usage in .NET Standard libraries and console applicaties.
410

511
For ASP.NET Core, use NLog.Web.AspNetCore: https://www.nuget.org/packages/NLog.Web.AspNetCore
612
</Description>
713

814
<Authors>Microsoft;Julian Verdurmen</Authors>
9-
<TargetFrameworks>net451;net461;netstandard1.5;netstandard2.0</TargetFrameworks>
10-
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
15+
<Company>NLog</Company>
1116
<AssemblyName>NLog.Extensions.Logging</AssemblyName>
1217
<AssemblyOriginatorKeyFile>NLog.snk</AssemblyOriginatorKeyFile>
1318
<SignAssembly>true</SignAssembly>
@@ -32,35 +37,32 @@ rc3: Support for .NET 4.6.1, support for message templates .NET standard 1.5+ an
3237
<FileVersion>1.0.0.0</FileVersion>
3338
<!-- FileVersion = AssemblyFileVersionAttribute, patched by AppVeyor -->
3439
</PropertyGroup>
35-
<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard1.5' Or '$(TargetFramework)' == 'net451' ">
40+
<PropertyGroup Condition=" '$(TargetFramework)' == 'net461' ">
41+
<DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences>
42+
</PropertyGroup>
43+
<PropertyGroup Condition=" '$(TargetFramework)' == 'net451' ">
44+
<DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences>
3645
<DefineConstants>$(DefineConstants);NETCORE1_0</DefineConstants>
3746
</PropertyGroup>
38-
<PropertyGroup>
39-
<DocumentationFile>bin\$(Configuration)\$(TargetFramework)\NLog.Extensions.Logging.xml</DocumentationFile>
47+
<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard1.5' ">
48+
<NetStandardImplicitPackageVersion>1.6.0</NetStandardImplicitPackageVersion>
49+
<DefineConstants>$(DefineConstants);NETCORE1_0</DefineConstants>
4050
</PropertyGroup>
4151
<ItemGroup>
4252
<PackageReference Include="NLog" Version="[4.5.0-rc02,5)" />
4353
</ItemGroup>
4454
<ItemGroup Condition=" '$(TargetFramework)' == 'net451' ">
45-
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="1.1.2" />
46-
<Reference Include="System.Xml" />
47-
<Reference Include="System.Runtime" />
48-
<Reference Include="System.Xml.Serialization" />
55+
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="1.0.2" />
4956
<Reference Include="System" />
5057
<Reference Include="Microsoft.CSharp" />
5158
</ItemGroup>
5259
<ItemGroup Condition=" '$(TargetFramework)' == 'net461' ">
5360
<PackageReference Include="Microsoft.Extensions.Logging" Version="2.0.0" />
54-
<Reference Include="System.Xml" />
55-
<Reference Include="System.Runtime" />
56-
<Reference Include="System.Xml.Serialization" />
5761
<Reference Include="System" />
5862
<Reference Include="Microsoft.CSharp" />
5963
</ItemGroup>
60-
6164
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.5' ">
62-
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="1.1.2" />
63-
<PackageReference Include="System.AppContext" Version="4.3.0" />
65+
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="1.0.2" />
6466
</ItemGroup>
6567
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
6668
<PackageReference Include="Microsoft.Extensions.Logging" Version="2.0.0" />

test/NLog.Extensions.Logging.Tests.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<PropertyGroup>
44
<RestoreProjectStyle>PackageReference</RestoreProjectStyle>
55

6-
<TargetFrameworks>netcoreapp1.1;netcoreapp2.0;net461</TargetFrameworks>
6+
<TargetFrameworks>netcoreapp1.1;netcoreapp2.0;net452;net461</TargetFrameworks>
77
</PropertyGroup>
88

99
<ItemGroup>
@@ -12,7 +12,7 @@
1212
<PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
1313
</ItemGroup>
1414

15-
<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.1' ">
15+
<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.1' or '$(TargetFramework)' == 'net452' ">
1616
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="1.1.1" />
1717
<PackageReference Include="Microsoft.Extensions.Logging" Version="1.1.2" />
1818
</ItemGroup>

0 commit comments

Comments
 (0)