Enable absolute_paths warning

Author: cschwan

Cargo.toml

@@ -84,6 +84,7 @@ too-many-lines = "allow"
 unreadable-literal = "allow"
 
 # restriction lints
+absolute_paths = "warn"
 allow_attributes = "deny"
 allow_attributes_without_reason = "deny"
 arbitrary_source_item_ordering = "warn"

pineappl/src/error.rs

@@ -1,5 +1,6 @@
 //! Error types for the `pineappl` library.
 
+use std::result::Result as StdResult;
 use thiserror::Error;
 
 /// Catch-all error for this crate.
@@ -14,4 +15,4 @@ pub enum Error {
 }
 
 /// Convenient result type using [`Error`].
-pub type Result<T> = std::result::Result<T, Error>;
+pub type Result<T> = StdResult<T, Error>;

pineappl/src/grid.rs

@@ -25,6 +25,7 @@ use serde::{Deserialize, Serialize};
 use std::collections::BTreeMap;
 use std::io::{BufRead, BufReader, BufWriter, Read, Write};
 use std::ops::{Bound, RangeBounds};
+use std::result::Result as StdResult;
 use std::{iter, mem};
 
 const BIN_AXIS: Axis = Axis(1);
@@ -379,7 +380,7 @@ impl Grid {
     pub fn evolve<
         'a,
         E: Into<anyhow::Error>,
-        S: IntoIterator<Item = std::result::Result<(OperatorSliceInfo, CowArray<'a, f64, Ix4>), E>>,
+        S: IntoIterator<Item = StdResult<(OperatorSliceInfo, CowArray<'a, f64, Ix4>), E>>,
     >(
         &self,
         slices: Vec<S>,

pineappl/src/interpolation.rs

@@ -366,6 +366,7 @@ fn lagrange_weights(i: usize, n: usize, u: f64) -> f64 {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use crate::packed_array::PackedArray;
     use float_cmp::Ulps as _;
     use float_cmp::assert_approx_eq;
 
@@ -516,7 +517,7 @@ mod tests {
             assert_approx_eq!(f64, node, ref_node, ulps = 4);
         }
 
-        let mut array = crate::packed_array::PackedArray::<f64>::new(vec![40, 50, 50]);
+        let mut array = PackedArray::<f64>::new(vec![40, 50, 50]);
         let ntuples = [[100000.0, 0.25, 0.5], [1000.0, 0.5, 0.5]];
         let weight = 1.0;
 
@@ -711,7 +712,7 @@ mod tests {
                 InterpMeth::Lagrange,
             ),
         ];
-        let mut array = crate::packed_array::PackedArray::<f64>::new(vec![40, 50, 50]);
+        let mut array = PackedArray::<f64>::new(vec![40, 50, 50]);
 
         let ntuple = [1000.0, 0.5, 0.5];
         let weight = 0.0;
@@ -741,7 +742,7 @@ mod tests {
             Map::ApplGridH0,
             InterpMeth::Lagrange,
         )];
-        let mut array = crate::packed_array::PackedArray::<f64>::new(vec![1]);
+        let mut array = PackedArray::<f64>::new(vec![1]);
 
         let ntuple = [90.0_f64.powi(2)];
         let weight = 1.0;

pineappl_applgrid/src/lib.rs

@@ -1,5 +1,6 @@
 //! TODO.
 
+#![expect(clippy::absolute_paths, reason = "does not work properly with cxx")]
 #![expect(
     clippy::arbitrary_source_item_ordering,
     reason = "does not work properly with cxx"

pineappl_capi/src/lib.rs

@@ -70,10 +70,12 @@ use pineappl::subgrid::{ImportSubgridV1, Subgrid as _};
 use std::collections::HashMap;
 use std::ffi::{CStr, CString};
 use std::fs::File;
+use std::io::Error as IoError;
 use std::mem;
 use std::os::raw::{c_char, c_void};
 use std::path::Path;
 use std::slice;
+use std::ptr;
 
 /// Select subgrid type optimization when passed to grid optimization (see `GridOptFlags::OPTIMIZE_SUBGRID_TYPE`).
 pub const PINEAPPL_GOF_OPTIMIZE_SUBGRID_TYPE: GridOptFlags = GridOptFlags::OPTIMIZE_SUBGRID_TYPE;
@@ -948,7 +950,7 @@ pub unsafe extern "C" fn pineappl_grid_delete_bins(
     bin_indices_len: usize,
 ) {
     let grid = unsafe { &mut *grid };
-    let bin_indices = unsafe { std::slice::from_raw_parts(bin_indices_ptr, bin_indices_len) };
+    let bin_indices = unsafe { slice::from_raw_parts(bin_indices_ptr, bin_indices_len) };
     grid.delete_bins(bin_indices);
 }
 
@@ -1730,7 +1732,7 @@ pub unsafe extern "C" fn pineappl_grid_new2(
     let convolutions = unsafe { slice::from_raw_parts(convolutions, nb_convolutions) }.to_vec();
 
     // Grid interpolations
-    let interp_slices = unsafe { std::slice::from_raw_parts(interps, interpolations) };
+    let interp_slices = unsafe { slice::from_raw_parts(interps, interpolations) };
     let interp_vecs: Vec<_> = interp_slices
         .iter()
         .map(|interp| {
@@ -1750,7 +1752,7 @@ pub unsafe extern "C" fn pineappl_grid_new2(
     let kinematics = unsafe { slice::from_raw_parts(kinematics, interp_vecs.len()) }.to_vec();
 
     // Scales. An array containing the values of `ScaleFuncForm` objects
-    let mu_scales = unsafe { std::slice::from_raw_parts(scales, 3) };
+    let mu_scales = unsafe { slice::from_raw_parts(scales, 3) };
 
     Box::new(Grid::new(
         bins,
@@ -1918,7 +1920,7 @@ pub unsafe extern "C" fn pineappl_grid_metadata(
 
     grid.metadata()
         .get(key.as_ref())
-        .map_or(std::ptr::null_mut(), |value| {
+        .map_or(ptr::null_mut(), |value| {
             CString::new(value.as_str()).unwrap().into_raw()
         })
 }
@@ -2492,7 +2494,7 @@ pub unsafe extern "C" fn pineappl_grid_evolve(
                 }
 
                 // we specify an arbitrary error type since we don't return an error anywhere
-                Ok::<_, std::io::Error>((operator_slice_info, array))
+                Ok::<_, IoError>((operator_slice_info, array))
             })
         })
         .collect();
@@ -2527,10 +2529,10 @@ pub unsafe extern "C" fn pineappl_grid_evolve(
 pub unsafe extern "C" fn pineappl_fktable_optimize(grid: *mut Grid, assumptions: FkAssumptions) {
     let grid = unsafe { &mut *grid };
     // SAFETY: this code has been copied from the `take_mut` crate
-    let read_grid = unsafe { std::ptr::read(grid) };
+    let read_grid = unsafe { ptr::read(grid) };
     let mut fktable = FkTable::try_from(read_grid)
         // UNWRAP: error handling in the CAPI is to abort
         .unwrap();
     fktable.optimize(assumptions);
-    unsafe { std::ptr::write(grid, fktable.into_grid()) };
+    unsafe { ptr::write(grid, fktable.into_grid()) };
 }

pineappl_cli/src/helpers.rs

@@ -12,6 +12,7 @@ use std::iter;
 use std::ops::RangeInclusive;
 use std::path::Path;
 use std::process::ExitCode;
+use std::result::Result as StdResult;
 use std::str::FromStr;
 
 pub const SCALES_VECTOR_REN_FAC: [(f64, f64, f64); 9] = [
@@ -79,7 +80,7 @@ pub struct ConvFuns {
 impl FromStr for ConvFuns {
     type Err = Error;
 
-    fn from_str(arg: &str) -> std::result::Result<Self, Self::Err> {
+    fn from_str(arg: &str) -> StdResult<Self, Self::Err> {
         // split from the left, as '=' characters are allowed in labels but not in names
         let (names, label) = arg.split_once('=').unwrap_or((arg, arg));
         let (lhapdf_names, members, conv_types) = names

pineappl_cli/tests/export.rs

@@ -1,6 +1,7 @@
 #![expect(missing_docs, reason = "non-public items will not be documented")]
 
 use assert_cmd::Command;
+use predicates::str as pred_str;
 
 #[cfg(feature = "applgrid")]
 use assert_fs::NamedTempFile;
@@ -139,7 +140,7 @@ fn export_applgrid() {
         ])
         .assert()
         .success()
-        .stdout(predicates::str::ends_with(EXPORT_APPLGRID_STR));
+        .stdout(pred_str::ends_with(EXPORT_APPLGRID_STR));
 }
 
 #[test]
@@ -159,7 +160,7 @@ fn export_nnlo_ak5_ptj_discard_non_matching_values() {
         ])
         .assert()
         .success()
-        .stdout(predicates::str::ends_with(EXPORT_NNLO_AK5_PTJ_STR));
+        .stdout(pred_str::ends_with(EXPORT_NNLO_AK5_PTJ_STR));
 }
 
 #[test]
@@ -179,7 +180,7 @@ fn export_nnlo_ak5_ptj_discard_non_matching_scales_alias() {
         ])
         .assert()
         .success()
-        .stdout(predicates::str::ends_with(EXPORT_NNLO_AK5_PTJ_STR));
+        .stdout(pred_str::ends_with(EXPORT_NNLO_AK5_PTJ_STR));
 }
 
 #[test]
@@ -199,7 +200,7 @@ fn export_nnlo_ak5_ptj_discard_non_matching_momentum_alias() {
         ])
         .assert()
         .success()
-        .stdout(predicates::str::ends_with(EXPORT_NNLO_AK5_PTJ_STR));
+        .stdout(pred_str::ends_with(EXPORT_NNLO_AK5_PTJ_STR));
 }
 
 #[test]
@@ -249,5 +250,5 @@ fn export_dis_applgrid() {
         ])
         .assert()
         .success()
-        .stdout(predicates::str::ends_with(EXPORT_DIS_APPLGRID_STR));
+        .stdout(pred_str::ends_with(EXPORT_DIS_APPLGRID_STR));
 }