Generalized indices: interpolator_mod#1878
Merged
vithikashah001 merged 4 commits intoJun 1, 2026
Merged
Conversation
added 2 commits
May 28, 2026 05:36
Add generalized indices support to interpolator_mod and enable the unit tests.
J-Lentz
requested review from
bensonr,
rem1776,
uramirez8707 and
vithikashah001
as code owners
Contributor
uramirez8707
left a comment
uramirez8707
left a comment
There was a problem hiding this comment.
Just a minor comment, but it looks good otherwise.
| end select | ||
| end do | ||
|
|
||
| interp_data = reshape(interp_buf, shape(interp_data), order=dim_map) |
Contributor
There was a problem hiding this comment.
Can we change this so that it only happens if the dim_map is not the default [1, 2, 3, 4]? Not sure if there is a performance penalty for doing this.
Contributor
Author
There was a problem hiding this comment.
2b309ec avoids the temporary buffer unless it's actually needed, and prints a NOTE when it's used. Only applicable to the 3D and 4D cases, since the reshape operation just replaces a copy operation in the 2D case, and therefore doesn't add an additional unnecessary copy.
uramirez8707
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add generalized indices support to
interpolator_modvia a newdim_orderargument, which has been added to the 2D, 3D, and 4D variants of theinterpolatorsubroutine.How Has This Been Tested?
Builds on the AMD box and tests pass using ifx 2025.2.0 and GCC 15.2.0.
Checklist:
make distcheckpasses