basis.py make decompose, reconstruct, recon_error single responsibility#17
Open
magnesium2400 wants to merge 7 commits into
Open
basis.py make decompose, reconstruct, recon_error single responsibility#17magnesium2400 wants to merge 7 commits into
magnesium2400 wants to merge 7 commits into
Conversation
Collaborator
magnesium2400
commented
May 1, 2026
magnesium2400
commented
- make stats.py so we have a standard for doing inner products too
…ruction_error. remove reconstruct_timeseries and .pyi
…nd clean up other functions
…into separate_recon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.