🎨 Palette: Add missing accessibility labels to icon buttons#71
Conversation
💡 What: Added `.accessibilityLabel` to icon-only buttons in `SettingsViews.swift` (Layer Stick Override reset button) and `OnScreenKeyboardSettingsView.swift` (Variables function icon). 🎯 Why: These buttons previously had `.help` modifiers for hover tooltips but lacked equivalent VoiceOver accessibility labels, making them inaccessible to screen readers. 📸 Before/After: Visuals remain unchanged, but screen reader accessibility is fixed. ♿ Accessibility: Ensures VoiceOver properly announces "Reset to base (inherit)" and "Contains variables that will be expanded" for the respective icons. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds ChangesAccessibility Label Additions
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What: Added
.accessibilityLabelto icon-only buttons inSettingsViews.swift(Layer Stick Override reset button) andOnScreenKeyboardSettingsView.swift(Variables function icon).🎯 Why: These buttons previously had
.helpmodifiers for hover tooltips but lacked equivalent VoiceOver accessibility labels, making them inaccessible to screen readers.📸 Before/After: Visuals remain unchanged, but screen reader accessibility is fixed.
♿ Accessibility: Ensures VoiceOver properly announces "Reset to base (inherit)" and "Contains variables that will be expanded" for the respective icons.
PR created automatically by Jules for task 281458812996500947 started by @NSEvent
Summary by CodeRabbit