Skip to content

🎨 Palette: Add missing accessibility labels to icon buttons#71

Open
NSEvent wants to merge 1 commit into
mainfrom
palette-a11y-fix-281458812996500947
Open

🎨 Palette: Add missing accessibility labels to icon buttons#71
NSEvent wants to merge 1 commit into
mainfrom
palette-a11y-fix-281458812996500947

Conversation

@NSEvent

@NSEvent NSEvent commented Jul 1, 2026

Copy link
Copy Markdown
Owner

💡 What: Added .accessibilityLabel to icon-only buttons in SettingsViews.swift (Layer Stick Override reset button) and OnScreenKeyboardSettingsView.swift (Variables function icon).
🎯 Why: These buttons previously had .help modifiers for hover tooltips but lacked equivalent VoiceOver accessibility labels, making them inaccessible to screen readers.
📸 Before/After: Visuals remain unchanged, but screen reader accessibility is fixed.
♿ Accessibility: Ensures VoiceOver properly announces "Reset to base (inherit)" and "Contains variables that will be expanded" for the respective icons.


PR created automatically by Jules for task 281458812996500947 started by @NSEvent

Summary by CodeRabbit

  • Accessibility
    • Improved screen reader support for the on-screen keyboard by adding descriptive labels to the variable indicator and the “Reset to base (inherit)” button.
    • No visible behavior or layout changes were made.

💡 What: Added `.accessibilityLabel` to icon-only buttons in `SettingsViews.swift` (Layer Stick Override reset button) and `OnScreenKeyboardSettingsView.swift` (Variables function icon).
🎯 Why: These buttons previously had `.help` modifiers for hover tooltips but lacked equivalent VoiceOver accessibility labels, making them inaccessible to screen readers.
📸 Before/After: Visuals remain unchanged, but screen reader accessibility is fixed.
♿ Accessibility: Ensures VoiceOver properly announces "Reset to base (inherit)" and "Contains variables that will be expanded" for the respective icons.

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 939a682f-5069-4886-8fb0-b159860044f6

📥 Commits

Reviewing files that changed from the base of the PR and between 95d4928 and 2e28c4a.

📒 Files selected for processing (2)
  • XboxControllerMapper/XboxControllerMapper/Views/MainWindow/OnScreenKeyboardSettingsView.swift
  • XboxControllerMapper/XboxControllerMapper/Views/MainWindow/SettingsViews.swift

📝 Walkthrough

Walkthrough

This PR adds accessibilityLabel modifiers to two existing SwiftUI controls: the variables-expansion indicator icon in QuickTextRowView and the "Reset to base (inherit)" button in layerOverrideSlider. No structural, behavioral, or logic changes are made.

Changes

Accessibility Label Additions

Layer / File(s) Summary
Add accessibility labels to indicator and reset button
XboxControllerMapper/.../OnScreenKeyboardSettingsView.swift, XboxControllerMapper/.../SettingsViews.swift
Adds accessibilityLabel modifiers to the variables-expansion indicator in QuickTextRowView and the "Reset to base (inherit)" reset button in layerOverrideSlider.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding missing accessibility labels to icon buttons.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-a11y-fix-281458812996500947

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant