Moved convert_str_to_bool to utils.py

Author: vshekar

microscope/plugins/grid_plugin.py

@@ -14,6 +14,7 @@
 from microscope.widgets.rubberband import ResizableRubberBand
 from microscope.widgets.color_button import ColorButton
 from microscope.plugins.base_plugin import BasePlugin
+from microscope.utils import convert_str_bool
 from qtpy.QtGui import QMouseEvent
 from collections import defaultdict
 
@@ -50,19 +51,6 @@ def __init__(self, parent: "Optional[Microscope]" = None):
         self._x_divs = 5
         self._y_divs = 5
 
-    def convert_str_bool(self, val):
-        """Converts a string representation of a boolean to a boolean value.
-
-        Args:
-            val (str): The string representation of the boolean.
-
-        Returns:
-            bool: The boolean value.
-        """
-        if isinstance(val, str):
-            return True if val.lower() == "true" else False
-        return val
-
     def read_settings(self, settings: Dict[str, Any]):
         """Reads the plugin's settings from a dictionary.
 
@@ -72,13 +60,13 @@ def read_settings(self, settings: Dict[str, Any]):
         self._grid_color = settings.get("color", QColor.fromRgb(0, 255, 0))
         self.start = settings.get("start", QPoint(0, 0))
         self.end = settings.get("end", QPoint(1, 1))
-        self.plugin_state["grid_hidden"] = self.convert_str_bool(
+        self.plugin_state["grid_hidden"] = convert_str_bool(
             settings.get("grid_hidden", False)
         )
-        self.plugin_state["selector_hidden"] = self.convert_str_bool(
+        self.plugin_state["selector_hidden"] = convert_str_bool(
             settings.get("selector_hidden", False)
         )
-        self.plugin_state["grid_defined"] = self.convert_str_bool(
+        self.plugin_state["grid_defined"] = convert_str_bool(
             settings.get("grid_defined", False)
         )
         self._x_divs = int(settings.get("x_divs", 5))

microscope/plugins/record_plugin.py

@@ -13,6 +13,7 @@
 from qtpy.QtGui import QImage, QPainter, QPen, QFont, QColor
 from microscope.plugins.base_plugin import BaseImagePlugin
 from microscope.widgets.color_button import ColorButton
+from microscope.utils import convert_str_bool
 from qtpy.QtGui import QMouseEvent
 from qtpy.QtCore import QThread, Signal, QObject, Qt, QTimer
 import cv2 as cv
@@ -329,14 +330,14 @@ def read_settings(self, settings: Dict[str, Any]):
         )
         self.hours_per_file = int(settings.get("hours_per_file", 1))
         self.number_of_files = int(settings.get("number_of_files", 1))
-        self.raw_image = True if settings.get("raw_image", "true") == "true" else False
-        self.timestamp = True if settings.get("timestamp", "true") == "true" else False
+        self.raw_image = convert_str_bool(settings.get("raw_image", True))
+        self.timestamp = convert_str_bool(settings.get("timestamp", False))
         self.timestamp_color = settings.get(
             "timestamp_color", QColor.fromRgb(0, 255, 0)
         )
         self.timestamp_font_size = int(settings.get("timestamp_font_size", 12))
         self.width = int(settings.get("image_width", 480))
-        self.use_epics_pv = bool(settings.get("use_epics", False))
+        self.use_epics_pv = convert_str_bool(settings.get("use_epics", True))
         self.epics_pv_name = str(settings.get("epics_pv", ""))
         self.setup_epics()
 

microscope/utils.py

@@ -0,0 +1,12 @@
+def convert_str_bool(val):
+    """Converts a string representation of a boolean to a boolean value.
+
+    Args:
+        val (str): The string representation of the boolean.
+
+    Returns:
+        bool: The boolean value.
+    """
+    if isinstance(val, str):
+        return True if val.lower() == "true" else False
+    return val