Skip to content

Commit 988af66

Browse files
Stefan Bindingsmb49
authored andcommitted
ALSA: hda: cs35l41: Check mailbox status of pause command after firmware load
BugLink: https://bugs.launchpad.net/bugs/2029199 Currently, we do not check the return status of the pause command, immediately after we load firmware. If the pause has failed, the firmware is not running. Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com> Link: https://lore.kernel.org/r/20230721151816.2080453-4-sbinding@opensource.cirrus.com Signed-off-by: Takashi Iwai <tiwai@suse.de> (cherry picked from commit 5299b79ca1a2a9b017b87da08563100b0da98e5b linux-next) Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
1 parent 1528436 commit 988af66

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

sound/pci/hda/cs35l41_hda.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -781,7 +781,12 @@ static int cs35l41_smart_amp(struct cs35l41_hda *cs35l41)
781781
goto clean_dsp;
782782
}
783783

784-
cs35l41_set_cspl_mbox_cmd(cs35l41->dev, cs35l41->regmap, CSPL_MBOX_CMD_PAUSE);
784+
ret = cs35l41_set_cspl_mbox_cmd(cs35l41->dev, cs35l41->regmap, CSPL_MBOX_CMD_PAUSE);
785+
if (ret) {
786+
dev_err(cs35l41->dev, "Error waiting for DSP to pause: %u\n", ret);
787+
goto clean_dsp;
788+
}
789+
785790
cs35l41->firmware_running = true;
786791

787792
return 0;

0 commit comments

Comments
 (0)