Skip to content

Commit 1fb789b

Browse files
authored
Remove ESM2, Amplify from 5D. This is now in bionemo-recipes (#1336)
### Description Remove 5D codepaths that are now covered by bionemo-recipes #### Usage <!--- How does a user interact with the changed code --> ```python TODO: Add code snippet ``` ### Type of changes <!-- Mark the relevant option with an [x] --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Refactor - [ ] Documentation update - [ ] Other (please describe): ### CI Pipeline Configuration Configure CI behavior by applying the relevant labels. By default, only basic unit tests are run. - [ciflow:skip](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/main/contributing/contributing.md#ciflow:skip) - Skip all CI tests for this PR - [ciflow:notebooks](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/main/contributing/contributing.md#ciflow:notebooks) - Run Jupyter notebooks execution tests for bionemo2 - [ciflow:slow](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/main/contributing/contributing.md#ciflow:slow) - Run slow single GPU integration tests marked as @pytest.mark.slow for bionemo2 - [ciflow:all](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/main/contributing/contributing.md#ciflow:all) - Run all tests (unit tests, slow tests, and notebooks) for bionemo2. This label can be used to enforce running tests for all bionemo2. - [ciflow:all-recipes](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/main/contributing/contributing.md#ciflow:all-recipes) - Run tests for all recipes (under bionemo-recipes). This label can be used to enforce running tests for all recipes. Unit tests marked as `@pytest.mark.multi_gpu` or `@pytest.mark.distributed` are not run in the PR pipeline. For more details, see [CONTRIBUTING](CONTRIBUTING.md) > [!NOTE] > By default, only basic unit tests are run. Add appropriate labels to enable an additional test coverage. #### Authorizing CI Runs We use [copy-pr-bot](https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/#automation) to manage authorization of CI runs on NVIDIA's compute resources. - If a pull request is opened by a trusted user and contains only trusted changes, the pull request's code will automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123) - If a pull request is opened by an untrusted user or contains untrusted changes, an NVIDIA org member must leave an `/ok to test` comment on the pull request to trigger CI. This will need to be done for each new commit. ### Pre-submit Checklist <!--- Ensure all items are completed before submitting --> - [ ] I have tested these changes locally - [ ] I have updated the documentation accordingly - [ ] I have added/updated tests as needed - [ ] All existing tests pass successfully --------- Signed-off-by: Timur Rvachov <trvachov@nvidia.com>
1 parent bf10c4d commit 1fb789b

110 files changed

Lines changed: 14 additions & 17773 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.devcontainer/framework/devcontainer.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,10 @@
4141
],
4242
"settings": {
4343
"python.analysis.extraPaths": [
44-
"./sub-packages/bionemo-fw/src",
4544
"./sub-packages/bionemo-core/src",
46-
"./sub-packages/bionemo-esm2/src",
4745
"./sub-packages/bionemo-geneformer/src",
4846
"./sub-packages/bionemo-llm/src",
4947
"./sub-packages/bionemo-testing/src",
50-
"./sub-packages/bionemo-amplify/src",
5148
"./sub-packages/bionemo-example_model/src",
5249
"./3rdparty/NeMo",
5350
"./3rdparty/Megatron-LM"

.secrets.baseline

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,9 @@
148148
"filename": "pyproject.toml",
149149
"hashed_secret": "79670e9c9d1c7ea5b81a96a2053d81437712c78e",
150150
"is_verified": false,
151-
"line_number": 44
151+
"line_number": 42
152152
}
153153
]
154154
},
155-
"generated_at": "2025-09-25T15:59:12Z"
155+
"generated_at": "2025-12-02T22:57:51Z"
156156
}

CODEOWNERS

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,16 +58,12 @@ ci/ @dorotat-nv @pstjohn @trvachov @jwilber @jomitchellnv @jstjohn
5858
#
5959
## LIBRARY CODE
6060
#
61-
sub-packages/bionemo-fw @DejunL @dorotat-nv @farhadrgh @jstjohn @pstjohn @skothenhill-nv
62-
6361
sub-packages/bionemo-testing @dorotat-nv @farhadrgh @jstjohn @pstjohn @skothenhill-nv
6462

6563
sub-packages/bionemo-core @DejunL @dorotat-nv @farhadrgh @jstjohn @pstjohn @skothenhill-nv
6664

6765
sub-packages/bionemo-llm @farhadrgh @dorotat-nv @jstjohn @pstjohn @skothenhill-nv
6866

69-
sub-packages/bionemo-esm2 @pstjohn @jstjohn @skothenhill-nv @jomitchellnv @farhadrgh @yzhang123 @polinabinder1
70-
7167
sub-packages/bionemo-example_model @jstjohn @skothenhill-nv
7268

7369
sub-packages/bionemo-geneformer @jstjohn @skothenhill-nv

README.md

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -78,17 +78,14 @@ A core use-case of the BioNeMo Framework is to help digital biology scientists a
7878
<summary><b>(Click to expand) <code>sub-packages</code> models support matrix</b></summary>
7979
<small>
8080

81-
| Directory | Description | Support | 5D Parallel | Megatron-FSDP | TE | Sequence Packing | FP8 | Context Parallel |
82-
| ----------------------- | ----------------------------------- | -------------- | ----------- | ------------- | --- | ---------------- | --- | ---------------- |
83-
| `bionemo-amplify` | 5D parallel model | 🔧 Maintenance |||||||
84-
| `bionemo-core` | Model Config/test data utils | ✅ Active || N/A ||| N/A | N/A |
85-
| `bionemo-esm2` | 5D parallel model | ✅ Active |||||||
86-
| `bionemo-evo2` | 5D parallel model | ✅ Active |||||||
87-
| `bionemo-example_model` | Example 5D parallel model | 🔧 Maintenance |||||||
88-
| `bionemo-fw` | Meta package to pull other packages | ✅ Active || N/A | N/A ||| N/A |
89-
| `bionemo-geneformer` | 5D parallel model | 🔧 Maintenance |||||||
90-
| `bionemo-llm` | 5D parallel base model (BioBert) | ✅ Active |||||||
91-
| `bionemo-testing` | Testing Utilities | ✅ Active || N/A | N/A | N/A | N/A | N/A |
81+
| Directory | Description | Support | 5D Parallel | Megatron-FSDP | TE | Sequence Packing | FP8 | Context Parallel |
82+
| ----------------------- | -------------------------------- | -------------- | ----------- | ------------- | --- | ---------------- | --- | ---------------- |
83+
| `bionemo-core` | Model Config/test data utils | ✅ Active || N/A ||| N/A | N/A |
84+
| `bionemo-evo2` | 5D parallel model | ✅ Active |||||||
85+
| `bionemo-example_model` | Example 5D parallel model | 🔧 Maintenance |||||||
86+
| `bionemo-geneformer` | 5D parallel model | 🔧 Maintenance |||||||
87+
| `bionemo-llm` | 5D parallel base model (BioBert) | ✅ Active |||||||
88+
| `bionemo-testing` | Testing Utilities | ✅ Active || N/A | N/A | N/A | N/A | N/A |
9289

9390
</small>
9491
</details>

ci/benchmarks/partial-conv/amplify_pretrain.yaml

Lines changed: 0 additions & 110 deletions
This file was deleted.

ci/benchmarks/partial-conv/esm2_finetuning.yaml

Lines changed: 0 additions & 97 deletions
This file was deleted.

ci/benchmarks/partial-conv/esm2_pretrain.yaml

Lines changed: 0 additions & 95 deletions
This file was deleted.

0 commit comments

Comments
 (0)