Skip to content

Commit fbcd380

Browse files
authored
Fix typos in documentation (#1435)
Documentation typo fixes (thanks ai). I also fixed the `!!! note` text sections that were missing the leading ` `, which caused inaccurate rendering (see image below): <img width="917" height="115" alt="image" src="https://github.com/user-attachments/assets/a0143254-437b-41fd-b038-12a38bd237a9" /> --------- Signed-off-by: jwilber <jwilber@nvidia.com>
1 parent 2913ea0 commit fbcd380

5 files changed

Lines changed: 16 additions & 17 deletions

File tree

docs/docs/main/about/releasenotes-fw.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
- ESM2 LoRA model inference issue resolved. https://github.com/NVIDIA/bionemo-framework/pull/996
4141
- Added experimental evo2-mamba model. https://github.com/NVIDIA/bionemo-framework/pull/888
4242
- Updated base Docker image to [nvidia-pytorch 25.06-py3](https://catalog.ngc.nvidia.com/orgs/nvidia/containers/pytorch/tags)
43-
- NCCL issue in ESM2 pretraing resolved. https://github.com/NVIDIA/bionemo-framework/issues/970
43+
- NCCL issue in ESM2 pretraining resolved. https://github.com/NVIDIA/bionemo-framework/issues/970
4444

4545
### What's Changed
4646

@@ -86,7 +86,7 @@
8686

8787
### Updates & Improvements
8888

89-
- Fixes around ESM2 pretraining and funetuning checkpoints.
89+
- Fixes around ESM2 pretraining and finetuning checkpoints.
9090
- Added sanity dataset for AMPLIFY testing.
9191
- Tested against A100 [brev](https://developer.nvidia.com/brev) instances.
9292
- Update `tornado` package to `>6.5.0` to fix container CVEs.

docs/docs/main/contributing/code-review.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -67,19 +67,19 @@ may collapse to a single review.
6767

6868
### 4. Coverage Check
6969

70-
Our repository has automated checks to ensure test coverage has not regresed.
70+
Our repository has automated checks to ensure test coverage has not regressed.
7171
The coverage check approvers will be the same as the Approval-list users. If
7272
codeline test coverage regresses, the Approvers must make a judgement call
73-
whether it is acceptible or not the merge the code. Occaisonally the coverage
73+
whether it is acceptable or not to merge the code. Occasionally the coverage
7474
check algorithm has a false positive (i.e. code coverage doesn't regress, yet
75-
coverage check approval is flagged by gitlab), and in this case Approvers are i
75+
coverage check approval is flagged by gitlab), and in this case Approvers are
7676
free to simply approve the false coverage regression.
7777

7878
## Responsibilities
7979

8080
### All Commenters (Reviewers, Owners, Approvers, etc.)
8181

82-
If a comment thread is start by anyone, it is expected that **the thread starter
82+
If a comment thread is started by anyone, it is expected that **the thread starter
8383
resolves the comment**. Resolving a thread by the original thread starter indicates
8484
that the person who started the discussion is happy with the outcome.
8585

@@ -207,7 +207,7 @@ a fruitful interaction across the team members.
207207

208208
- Follow code styling and rules stated in the project's documents
209209
(for example, [contributing.md](contributing.md), of which the [Google Python
210-
Style Guide](https://google.github.io/styleguide/pyguide.html) is a subet) as these define the
210+
Style Guide](https://google.github.io/styleguide/pyguide.html) is a subset) as these define the
211211
look and feel of the code which defines the most fundamentals of how the code should be
212212
developed and allows reviewers to focus on the most important aspects of a new piece of code.
213213
For bash scripting please follow the Google Shell Style Guide [here](https://google.github.io/styleguide/shellguide.html)
@@ -252,7 +252,7 @@ a fruitful interaction across the team members.
252252
that approves the change must review the entire change holistically
253253
If you are a code owner of a particular file, it is appropriate to only reviews the files you own.
254254

255-
- If request an PR change their code, you are responsible for giving concrete
255+
- If you request a PR to change their code, you are responsible for giving concrete
256256
recommendations for what could be changed to resolve the issue the
257257
patch addresses. If you feel strongly that a patch should NEVER be
258258
merged, you are responsible for defending your position and
@@ -461,7 +461,7 @@ a fruitful interaction across the team members.
461461
production, we put them inside the `bionemo2/contrib` folder. This allows for teams to develop
462462
faster (less strict reviews) while testing code. When a feature is
463463
complete and well tested, we move it to `bionemo2/src` or
464-
`bionemo2/core` and we complete all the requirements for productroduction.
464+
`bionemo2/core` and we complete all the requirements for production.
465465

466466
## References
467467

docs/docs/main/contributing/contributing.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Signed-off-by: Your Name <your@email.com>
3131
```
3232

3333
If you would like this to happen automatically to all of your commits, you can modify
34-
your local `~/.git-config-template.txt` file. You can do this with a command like the
34+
your local `~/.git-commit-template.txt` file. You can do this with a command like the
3535
following:
3636

3737
```
@@ -109,7 +109,7 @@ submitting. Labels can be accessed in the right sidebar of the GitHub user inter
109109

110110
### CI Pipeline Configuration Controls
111111

112-
CI pipeline behavior can be controlled labels to optimize test execution:
112+
CI pipeline behavior can be controlled by labels to optimize test execution:
113113

114114
Key behaviors:
115115

@@ -181,9 +181,9 @@ For both internal and external developers, the next step is opening a PR:
181181
[requested](https://help.github.com/en/articles/creating-a-pull-request) to merge the changes from a branch of the
182182
fork or branch into `main`.
183183
- Exercise caution when selecting the source and target branches for the PR.
184-
Note that versioned releases of TensorRT OSS are posted to `release/` branches of the upstream repo.
185-
- Creation of a PR creation kicks off the code review process.
186-
- At least one TensorRT engineer will be assigned for the review.
184+
Note that versioned releases of BioNeMo are posted to `release/` branches of the upstream repo.
185+
- Creation of a PR kicks off the code review process.
186+
- At least one BioNeMo engineer will be assigned for the review.
187187
- While under review, mark your PRs as work-in-progress by prefixing the PR title with [WIP].
188188
2. Once ready, CI can be started by a developer with permissions when they add a `/build-ci` comment. This must pass
189189
prior to merging.

docs/docs/main/getting-started/pre-reqs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Before you begin using the BioNeMo Framework, ensure the hardware and software prerequisites outlined below are
44
met.
55

6-
## Hardware Prequisites
6+
## Hardware Prerequisites
77

88
The BioNeMo Framework is compatible with environments that have access to NVIDIA GPUs. `bfloat16` precision requires an
99
Ampere generation GPU or higher ([Compute Capability ≥8.0](https://developer.nvidia.com/cuda-gpus)). You may be able

docs/docs/main/getting-started/training-models.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
# Training Models
22

33
!!! note "5D Parallel Training Moved to bionemo-recipes"
4-
The 5D parallel training implementations for ESM-2 and Geneformer have been migrated to simplified TransformerEngine + FSDP implementations in [bionemo-recipes](https://github.com/NVIDIA/bionemo-framework/tree/main/bionemo-recipes). For training these models, please refer to the recipes in `bionemo-recipes/recipes/` (e.g., `esm2_native_te`, `geneformer_native_te_mfsdp_fp8`). The instructions below work for bi
5-
onemo-framework container releases \<2.7.1.
4+
The 5D parallel training implementations for ESM-2 and Geneformer have been migrated to simplified TransformerEngine + FSDP implementations in [bionemo-recipes](https://github.com/NVIDIA/bionemo-framework/tree/main/bionemo-recipes). For training these models, please refer to the recipes in `bionemo-recipes/recipes/` (e.g., `esm2_native_te`, `geneformer_native_te_mfsdp_fp8`). The instructions below work for bionemo-framework container releases \<2.7.1.
65

76
## Pydantic Configuration
87

0 commit comments

Comments
 (0)