chore(detect): drop unused build_validation_skeleton helper

build_validation_skeleton has been dead since chunked validation moved
skeleton construction inline into chunked_validate_row. No internal
callers remain; its tests go with it.

Made-with: Cursor

Author: lipikaramaswamy

src/anonymizer/engine/detection/custom_columns.py

@@ -34,7 +34,6 @@
     COL_VALIDATED_SEED_ENTITIES,
     COL_VALIDATION_CANDIDATES,
     COL_VALIDATION_DECISIONS,
-    COL_VALIDATION_SKELETON,
 )
 from anonymizer.engine.detection.postprocess import (
     EntitySpan,
@@ -52,8 +51,6 @@
     ValidatedDecisionSchema,
     ValidatedDecisionsSchema,
     ValidationCandidatesSchema,
-    ValidationSkeletonDecisionSchema,
-    ValidationSkeletonSchema,
 )
 
 
@@ -135,19 +132,6 @@ def prepare_validation_inputs(row: dict[str, Any]) -> dict[str, Any]:
     return row
 
 
-@custom_column_generator(required_columns=[COL_SEED_VALIDATION_CANDIDATES])
-def build_validation_skeleton(row: dict[str, Any]) -> dict[str, Any]:
-    """Pre-populate the decisions template with candidate IDs so the LLM only fills in decision/reason."""
-    candidates = ValidationCandidatesSchema.from_raw(row.get(COL_SEED_VALIDATION_CANDIDATES, {}))
-    skeleton = ValidationSkeletonSchema(
-        decisions=[
-            ValidationSkeletonDecisionSchema(id=c.id, value=c.value, label=c.label) for c in candidates.candidates
-        ]
-    )
-    row[COL_VALIDATION_SKELETON] = skeleton.model_dump(mode="json")
-    return row
-
-
 @custom_column_generator(
     required_columns=[COL_VALIDATION_DECISIONS, COL_SEED_VALIDATION_CANDIDATES],
 )

tests/engine/test_detection_custom_columns.py

@@ -26,12 +26,10 @@
     COL_VALIDATED_SEED_ENTITIES,
     COL_VALIDATION_CANDIDATES,
     COL_VALIDATION_DECISIONS,
-    COL_VALIDATION_SKELETON,
 )
 from anonymizer.engine.detection.custom_columns import (
     _parse_entity_spans,
     apply_validation_and_finalize,
-    build_validation_skeleton,
     enrich_validation_decisions,
     merge_and_build_candidates,
     parse_detected_entities,
@@ -144,57 +142,6 @@ def test_enrich_validation_decisions_ignores_non_dict_validation_payload() -> No
     assert result[COL_VALIDATED_ENTITIES] == {"decisions": []}
 
 
-def test_build_validation_skeleton_produces_null_decisions() -> None:
-    row: dict[str, Any] = {
-        COL_SEED_VALIDATION_CANDIDATES: {
-            "candidates": [
-                {
-                    "id": "first_name_0_5",
-                    "value": "Alice",
-                    "label": "first_name",
-                    "context_before": "",
-                    "context_after": " works",
-                },
-                {
-                    "id": "org_15_19",
-                    "value": "Acme",
-                    "label": "organization",
-                    "context_before": "at ",
-                    "context_after": "",
-                },
-            ]
-        },
-    }
-    result = build_validation_skeleton(row)
-    skeleton = result[COL_VALIDATION_SKELETON]
-    assert len(skeleton["decisions"]) == 2
-    assert skeleton["decisions"][0]["id"] == "first_name_0_5"
-    assert skeleton["decisions"][0]["value"] == "Alice"
-    assert skeleton["decisions"][0]["label"] == "first_name"
-    assert skeleton["decisions"][0]["decision"] is None
-    assert skeleton["decisions"][0]["proposed_label"] is None
-    assert skeleton["decisions"][1]["id"] == "org_15_19"
-
-
-def test_build_validation_skeleton_handles_candidates_with_missing_keys() -> None:
-    row: dict[str, Any] = {
-        COL_SEED_VALIDATION_CANDIDATES: {
-            "candidates": [
-                {"id": "x"},
-                {"value": "Alice"},
-                {},
-            ]
-        },
-    }
-    result = build_validation_skeleton(row)
-    skeleton = result[COL_VALIDATION_SKELETON]
-    assert len(skeleton["decisions"]) == 3
-    assert skeleton["decisions"][0]["id"] == "x"
-    assert skeleton["decisions"][0]["value"] == ""
-    assert skeleton["decisions"][1]["id"] == ""
-    assert skeleton["decisions"][1]["value"] == "Alice"
-
-
 def test_apply_validation_and_finalize_handles_malformed_merged_entities() -> None:
     row: dict[str, Any] = {
         COL_TEXT: "Alice works at Acme.",