File tree Expand file tree Collapse file tree
.claude/skills/model-onboarding Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -298,6 +298,23 @@ Add fully commented example configs under `examples/`:
298298
299299---
300300
301+ ## Phase 6: Parity Testing
302+
303+ After implementation and unit tests are complete, run the full parity-testing
304+ workflow to verify that the new model produces numerically equivalent results to
305+ the reference HuggingFace implementation.
306+
307+ ** Read and follow the parity-testing skill** at
308+ ` .claude/skills/parity-testing/SKILL.md ` . It walks through three levels of
309+ comparison (state-dict round-trip, component-level parity, end-to-end forward
310+ pass) and provides debugging steps when a level fails.
311+
312+ Do not skip this phase. A model that passes unit tests can still diverge from HF
313+ due to subtle weight-conversion bugs, backend differences, or RoPE mismatches
314+ that only surface in a full parity comparison.
315+
316+ ---
317+
301318## Key Files Reference
302319
303320| File | Purpose |
@@ -336,4 +353,5 @@ Add fully commented example configs under `examples/`:
336353- [ ] Created layer equivalence tests for every rewritten layer (matching model dtype)
337354- [ ] Created functional tests (training loss decreases)
338355- [ ] Updated docs/model-coverage page
356+ - [ ] Ran parity-testing skill (state-dict round-trip, component parity, E2E forward pass)
339357- [ ] Set ` ModelClass = <Name>ForCausalLM ` at module bottom
You can’t perform that action at this time.
0 commit comments