Skip to content

Commit 6266832

Browse files
authored
fix: lint in llava_onevision (#1884)
fix lint Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
1 parent c4c5131 commit 6266832

2 files changed

Lines changed: 3 additions & 16 deletions

File tree

nemo_automodel/components/models/llava_onevision/rice_vit.py

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@
1818

1919
import torch
2020
import torch.nn as nn
21-
import torch.nn.functional as F
2221
from torch.nn import LayerNorm
23-
2422
from transformers.activations import ACT2FN
2523

2624

@@ -80,15 +78,11 @@ def __init__(
8078
self.embed_dim = embed_dim
8179

8280
kernel_size = [patch_size, patch_size]
83-
self.proj = nn.Conv2d(
84-
in_channels, embed_dim, kernel_size=kernel_size, stride=kernel_size, bias=False
85-
)
81+
self.proj = nn.Conv2d(in_channels, embed_dim, kernel_size=kernel_size, stride=kernel_size, bias=False)
8682

8783
def forward(self, hidden_states: torch.Tensor) -> torch.Tensor:
8884
target_dtype = self.proj.weight.dtype
89-
hidden_states = hidden_states.view(
90-
-1, self.in_channels, self.patch_size, self.patch_size
91-
)
85+
hidden_states = hidden_states.view(-1, self.in_channels, self.patch_size, self.patch_size)
9286
hidden_states = self.proj(hidden_states.to(dtype=target_dtype)).view(-1, self.embed_dim)
9387
return hidden_states
9488

@@ -148,12 +142,7 @@ def forward(
148142
position_embeddings: Optional[Tuple[torch.Tensor, torch.Tensor]] = None,
149143
) -> torch.Tensor:
150144
seq_length = hidden_states.shape[0]
151-
q, k, v = (
152-
self.qkv(hidden_states)
153-
.reshape(seq_length, 3, self.num_heads, -1)
154-
.permute(1, 0, 2, 3)
155-
.unbind(0)
156-
)
145+
q, k, v = self.qkv(hidden_states).reshape(seq_length, 3, self.num_heads, -1).permute(1, 0, 2, 3).unbind(0)
157146

158147
if position_embeddings is None:
159148
emb = torch.cat((rotary_pos_emb, rotary_pos_emb), dim=-1)

nemo_automodel/components/models/llava_onevision/state_dict_adapter.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
import re
1717
from typing import Any, Optional
1818

19-
import torch
20-
2119
from nemo_automodel.components.checkpoint.state_dict_adapter import StateDictAdapter
2220

2321

0 commit comments

Comments
 (0)