feat: FSDP2 w weight prefetching and async TP optimization#1711
Merged
ZhiyuLi-Nvidia merged 19 commits intomainfrom Apr 10, 2026
Merged
feat: FSDP2 w weight prefetching and async TP optimization#1711ZhiyuLi-Nvidia merged 19 commits intomainfrom
ZhiyuLi-Nvidia merged 19 commits intomainfrom
Conversation
Contributor
Author
|
/ok to test 1b4762a |
1b4762a to
0d9ffef
Compare
Contributor
Author
|
/ok to test 0d9ffef |
0d9ffef to
295ed82
Compare
Contributor
Author
|
/ok to test 295ed82 |
Contributor
Author
|
/ok to test 03ee22d |
Contributor
Author
|
/ok to test 2ab2123 |
jgerh
reviewed
Apr 9, 2026
Contributor
jgerh
left a comment
There was a problem hiding this comment.
Did another tech pubs pass on docs/performance-summary.md. Found a few dup entries and link issues. Please check and verify suggestions.
Contributor
|
/ok to test 4120722 |
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
…frastructure Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Contributor
Author
|
/ok to test 77d24bd |
Contributor
Author
|
/ok to test 592f9c8 |
akoumpa
approved these changes
Apr 10, 2026
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Perf Improvement:
FSDP2 throughput optimizations + removal of combined projection modules.
FSDP2 Optimizations (
FSDP2Confignew flags)enable_async_tensor_parallel): overlaps ReduceScatter with compute via_micro_pipeline_tp; requiressequence_parallel=Trueenable_compile): appliestorch.compileafter checkpoint load to avoid_orig_modkey mismatchespatch_is_packed_sequence: removes per-layer CPU-GPU sync (aten::is_nonzero) and enables static shapes for compileCompile Compatibility
TPLinear: replacesF.linearwithbmmto avoidaten.viewcrashes on sharded DTensor in AOT-autograd backward_patch_dtensor_spec_hash_for_symint: fixesDTensorSpechash crash whentorch.compileuses symbolic shapesCombined Projection Depreciation
CombinedQKVAttentionMixin,CombinedGateUpMLP, andCombinedProjectionStateDictAdapterq/k/vandgate/upprojections — simplifies TP sharding and state dict handlingTest plan
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information