cp: FSDP2 w weight prefetching and async TP optimization (#1711)#1779
Merged
cp: FSDP2 w weight prefetching and async TP optimization (#1711)#1779
Conversation
* feat: FSDP2 w weight prefetching and async TP optimization Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * remove deferred rs feature Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * add datapoints Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * lint Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * fix unit tests Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * address claude review Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * remove invalid tests and better readbility Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * skip unused fsdp flag Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * Apply suggestions from code review Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * refactor: use nn.Module.compile() and consolidate compile paths in infrastructure Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * refactor: remove fsdp_layer_group_size flag Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * derive pp_enabled Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * lint Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * update cp and fix Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * lint Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * update perf Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * update Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * update perf Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> * fix test Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> --------- Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> Co-authored-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com> Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
ZhiyuLi-Nvidia
requested review from
HuiyingLi,
adil-a,
akoumpa,
hemildesai,
jgerh and
pthombre
as code owners
Contributor
Author
|
/ok to test 80fe774 |
akoumpa
changed the title
akoumpa
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually cherry-pick #1711 to
r0.4.0Conflicts break auto cherry-pick caused given missing
fix: Allow use_cache w/ activation_checkpointing (1726)intor0.4.0#1760