cp: Update NDD (nemo data-designer) version (1755) into r1.2.0#1849
cp: Update NDD (nemo data-designer) version (1755) into r1.2.0#1849
Update NDD (nemo data-designer) version (1755) into r1.2.0#1849Conversation
* update ndd version Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Update pyproject.toml Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Update fsspec override comment to clarify nemo-toolkit[asr] conflict nemo-toolkit[asr]==2.7.2 pins fsspec==2024.12.0, which conflicts with data-designer-engine==0.5.5 requiring fsspec>=2025.3.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Regenerate uv.lock with updated fsspec override Updates lock file to reflect fsspec>=2025.3.0 override needed due to nemo-toolkit[asr]==2.7.2 pinning fsspec==2024.12.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Cap protobuf <7.0 to fix Ray Serve FieldDescriptor API breakage protobuf 7.x dropped the .label attribute from the C extension FieldDescriptor, breaking ray/serve/_private/config.py:75. Cap to <7.0 in both constraint-dependencies and override-dependencies so uv resolves to 6.x (was bumping to 7.34.1 after lock regeneration). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Cap vllm <0.16.0 to fix Ray Serve LLMServer deployment failure ray[llm]==2.54 is incompatible with vllm>=0.16.0 which renamed internal modules (translations -> speech_to_text), causing LLMServer to hit DEPLOY_FAILED. Cap vllm to <0.16.0 until ray[llm] adds support. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Address comments Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Remove hard pins and rely on base uvlock deps Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Forgot to update ray-serve pin Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> --------- Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> Signed-off-by: Huy Vu <86480512+huvunvidia@users.noreply.github.com> Co-authored-by: Huy Vu2 <huvu@login-eos02.eos.clusters.nvidia.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
|
/ok to test a153a53 |
Greptile SummaryThis cherry-pick (from #1755) upgrades Confidence Score: 5/5Safe to merge — straightforward dependency version bump with well-motivated upper bounds and a consistent lock file regeneration. All changes are dependency metadata (pyproject.toml + uv.lock). Every new constraint is accompanied by an explanatory comment, the sdg_cuda12 extra correctly pulls in sdg_cpu (so the data-designer pin propagates), and no application logic is touched. No P0/P1 findings. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[pyproject.toml changes] --> B[data-designer==0.5.5]
A --> C[vllm<0.16.0\nx86_64 non-Darwin only]
A --> D[protobuf>=5.29.6,<7.0\nCVE fix + ray serve guard]
A --> E[fsspec>=2025.3.0 override]
B --> F[data-designer-config 0.5.5]
B --> G[data-designer-engine 0.5.5]
G --> H[+ chardet\n+ fsspec\n- litellm]
F --> I[+ pillow]
G --> J[duckdb 1.5.2\nTransitive bump]
E --> K[Overrides nemo-toolkit\nfsspec==2024.12.0 pin]
Reviews (1): Last reviewed commit: "Update NDD (nemo data-designer) version ..." | Re-trigger Greptile |
beep boop [🤖]: Hi @huvunvidia 👋,