Skip to content
This repository was archived by the owner on May 20, 2026. It is now read-only.

VFM : Init repo#1

Merged
pablo-garay merged 8 commits into
mainfrom
pagaray_vfm_init_repo
Jun 24, 2025
Merged

VFM : Init repo#1
pablo-garay merged 8 commits into
mainfrom
pagaray_vfm_init_repo

Conversation

@pablo-garay

@pablo-garay pablo-garay commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@pablo-garay
pablo-garay requested a review from chtruong814 June 18, 2025 21:21
chtruong814
chtruong814 reviewed Jun 19, 2025
View reviewed changes

@chtruong814 chtruong814 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Had some comments around the naming. Feel free to manually take care of that here but ideally we also clean up the template too.

Comment thread vfm/package_info.py Outdated
__version__ = ".".join(map(str, VERSION[:3])) + "".join(VERSION[3:])

__package_name__ = "vfm"
__contact_names__ = "VFM"

@chtruong814 chtruong814 Jun 19, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have made the template better. Could you update the template so that __contact_names__ = "NVIDIA"?

@pablo-garay pablo-garay Jun 22, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread vfm/package_info.py Outdated

__package_name__ = "vfm"
__contact_names__ = "VFM"
__contact_emails__ = "contact@example.com"

@chtruong814 chtruong814 Jun 19, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update template so this is __contact_emails__ = "nemo-toolkit@nvidia.com" for now. I can double check later if we should be using something different.

@pablo-garay pablo-garay Jun 22, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread vfm/__init__.py Outdated
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
from vfm.package_info import (

@chtruong814 chtruong814 Jun 19, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using the cookie cutter template, instead of just vfm, let's have project name be NeMo VFM. The repo name will just be VFM. But the package and project would be referenced as NeMo VFM or nemo_vfm, etc...

@pablo-garay pablo-garay Jun 22, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

chtruong814
chtruong814 reviewed Jun 24, 2025
View reviewed changes

@chtruong814 chtruong814 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we're not terribly consistent on the copyright in the template. Would you please resolve those and we can go ahead and get this merged?

Comment thread nemo_vfm/__init__.py Outdated
@@ -0,0 +1,26 @@
# Copyright (c) 2025, NeMo VFM.

@chtruong814 chtruong814 Jun 24, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the template must be wrong here. Could you review the copyright in the template to make sure it's set to

Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION.  All rights reserved.

Comment thread nemo_vfm/package_info.py Outdated
@@ -0,0 +1,35 @@
# Copyright (c) 2025, NeMo VFM.

@chtruong814 chtruong814 Jun 24, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another place to be updating the copyright template

Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION.  All rights reserved.

Comment thread tests/unit_tests/test_placeholder.py Outdated
@@ -0,0 +1,18 @@
# Copyright (c) 2025, NeMo VFM.

@chtruong814 chtruong814 Jun 24, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another place to be updating the copyright template

Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION.  All rights reserved.

Comment thread tests/unit_tests/L0_Unit_Tests_GPU.sh Outdated
@@ -0,0 +1,14 @@
# Copyright (c) 2025, NVIDIA CORPORATION.

@chtruong814 chtruong814 Jun 24, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another place to be updating the copyright template

Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION.  All rights reserved.

Comment thread tests/unit_tests/L0_Unit_Tests_CPU.sh Outdated
@@ -0,0 +1,14 @@
# Copyright (c) 2025, NVIDIA CORPORATION.

@chtruong814 chtruong814 Jun 24, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another place to be updating the copyright template

Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION.  All rights reserved.

Comment thread .github/workflows/close-inactive-issue-pr.yml Outdated
@@ -0,0 +1,38 @@
# Copyright (c) 2025, NVIDIA CORPORATION.

@chtruong814 chtruong814 Jun 24, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another place to be updating the copyright template

Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION.  All rights reserved.

Comment thread .github/workflows/cicd-main.yml Outdated
@@ -0,0 +1,252 @@
# Copyright (c) 2025, NVIDIA CORPORATION.

@chtruong814 chtruong814 Jun 24, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another place to be updating the copyright template

Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION.  All rights reserved.

Comment thread .github/workflows/build-test-publish-wheel.yml Outdated
@@ -0,0 +1,40 @@
# Copyright (c) 2025, NVIDIA CORPORATION.

@chtruong814 chtruong814 Jun 24, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another place to be updating the copyright template

Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION.  All rights reserved.

Comment thread .github/workflows/_build_container.yml Outdated
@@ -0,0 +1,83 @@
# Copyright (c) 2025, NVIDIA CORPORATION.

@chtruong814 chtruong814 Jun 24, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another place to be updating the copyright template

Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION.  All rights reserved.

Comment thread .github/actions/test-template/action.yml Outdated
@@ -0,0 +1,251 @@
# Copyright (c) 2025, NVIDIA CORPORATION.

@chtruong814 chtruong814 Jun 24, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another place to be updating the copyright template

Copyright (c) {{cookiecutter.year}}, NVIDIA CORPORATION.  All rights reserved.

@pablo-garay
pablo-garay merged commit aefceda into main Jun 24, 2025
2 checks passed
@chtruong814
chtruong814 deleted the pagaray_vfm_init_repo branch January 29, 2026 20:21
huvunvidia pushed a commit that referenced this pull request Feb 12, 2026
@pablo-garay
Merge pull request #1 from NVIDIA-NeMo/pagaray_vfm_init_repo
01e3c5d 
VFM : Init repo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@chtruong814 chtruong814 chtruong814 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pablo-garay @chtruong814