CPU & GPU: init + sample tests#24
Conversation
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
7a903b0 to
df59692
Compare
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
|
/ok to test b17ecc4 |
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
|
/ok to test b8d0ed5 |
|
/ok to test 5888465 |
abhinavg4
left a comment
abhinavg4
left a comment
There was a problem hiding this comment.
looks good right now, but we will need to make sure that dockerfile has Mcore path also installed
| FROM nvcr.io/nvidia/pytorch:25.09-py3 | ||
|
|
||
| WORKDIR /workspace | ||
|
|
There was a problem hiding this comment.
Can you please take a look at this dockerfile. We would want to copy their changes for the Mcore path:
https://github.com/NVIDIA-NeMo/Megatron-Bridge/blob/main/docker/Dockerfile.ci
I don't think we need third_party/mcore relates installations but can you please take a look if the overall dockerfile looks similar ?
There was a problem hiding this comment.
yes i can do :)
will address in follow up PR ; SG thankss👍
There was a problem hiding this comment.
Looks similar. MegatronBridge is using that thirdparty/mcore install though
| COPY pyproject.toml uv.lock ./ | ||
|
|
||
| # Install test dependencies using uv sync | ||
| RUN uv sync --link-mode copy --locked --group test --no-install-project |
There was a problem hiding this comment.
I think we need to think this through. This is only installing automodel path right now. We will also need Mcore path
There was a problem hiding this comment.
yes i can do :)
will address in follow up PR ; SG thankss👍
CPU & GPU: init + sample tests
3 participants
Uh oh!
There was an error while loading. Please reload this page.