This repository was archived by the owner on May 20, 2026. It is now read-only.
feat: ruff for linting#26
Merged
Merged
Conversation
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
ko3n1g
reviewed
Nov 4, 2025
ko3n1g
left a comment
ko3n1g
left a comment
Contributor
There was a problem hiding this comment.
I think formatting may have destroyed some encodings? Also a question regarding the linting workflow.
| # limitations under the License. | ||
|
|
||
| name: Ruff Linter | ||
| on: [push, pull_request] |
Contributor
There was a problem hiding this comment.
This means the workflow would run twice per PR. Is that desired?
Contributor
Author
There was a problem hiding this comment.
good catch, updated
chtruong814
reviewed
Nov 4, 2025
chtruong814
reviewed
Nov 4, 2025
chtruong814
reviewed
Nov 4, 2025
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
chtruong814
approved these changes
Nov 5, 2025
chtruong814
left a comment
chtruong814
left a comment
Collaborator
There was a problem hiding this comment.
Please ensure status checks we care about are reflected in required checks in branch rules.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.