fix(models): apply warn_at_caller to remaining deprecation sites

greptile-apps (PR #594, r3189904028): `ProviderRepository.load`'s
YAML-default `DeprecationWarning` was using `warnings.warn(stacklevel=2)`,
which attributes to whichever data_designer frame called `load()` —
controllers, services, list/reset commands, agent introspection. Every
real call path lands on `data_designer.cli.*`, which falls under
Python's default `ignore::DeprecationWarning` filter and is silenced.
Audit found two more sites with the same problem:

- `DatasetBuilder._resolve_async_compatibility` (`allow_resize` /
  issue #552) — was using `stacklevel=4` to walk past
  `_resolve_async_compatibility -> build/build_preview -> interface ->
  user`. Brittle: any added frame (decorator, async wrapping, the
  `try/except DeprecationWarning: raise` boundary) shifts attribution
  silently. The existing test passed only because it used
  `simplefilter("always") + record=True`, which records warnings
  regardless of attribution.
- `ProviderController._handle_change_default` — was using
  `stacklevel=2`, which lands on the menu dispatcher in the same
  controller module. `print_warning` already shows the message
  visually, but programmatic observers (`pytest.warns`,
  `filterwarnings("error", ...)`) saw a library-attributed entry that
  default filters silenced.

All three migrated to `warn_at_caller` (the helper from 247fa30) so
attribution lands on the user's call site regardless of internal
chain shape. `data_designer` is already in
`DEFAULT_INTERNAL_PREFIXES`, so the walk escapes the entire library
in one pass.

Added attribution regression tests at each site asserting
`warning.filename == __file__`. A future regression to
`warnings.warn(stacklevel=N)` now fails CI instead of silently
silencing the user-facing nudge:

- `test_load_with_yaml_default_attributes_warning_to_caller`
  (test_provider_repository.py)
- `test_resolve_async_compatibility` extended with the same assertion
- `test_handle_change_default_emits_deprecation_warning` rewritten
  from `pytest.warns(...)` to a `catch_warnings(record=True)` block
  that filters for the message and asserts `filename == __file__`
  (`pytest.warns` does not check attribution, so the rewrite is
  required to actually catch the regression).

3,125 tests pass (548 config + 1,923 engine + 654 interface).

Refs #589

Author: nabinchha

packages/data-designer-engine/src/data_designer/engine/dataset_builders/dataset_builder.py

@@ -9,7 +9,6 @@
 import os
 import time
 import uuid
-import warnings
 from pathlib import Path
 from typing import TYPE_CHECKING, Any, Callable
 
@@ -23,6 +22,7 @@
     ProcessorConfig,
     ProcessorType,
 )
+from data_designer.config.utils.warning_helpers import warn_at_caller
 from data_designer.config.version import get_library_version
 from data_designer.engine.column_generators.generators.base import (
     ColumnGenerator,
@@ -319,7 +319,17 @@ def _resolve_async_compatibility(self) -> bool:
                 "use workflow chaining instead (see issue #552)."
             )
             logger.warning(f"⚠️ {msg}")
-            warnings.warn(msg, DeprecationWarning, stacklevel=4)
+            # ``warn_at_caller`` rather than ``warnings.warn(stacklevel=N)`` so
+            # attribution lands on the user's call site instead of an internal
+            # ``DatasetBuilder.build`` / ``data_designer.interface`` frame.
+            # The exact internal-frame depth from this method up to user code
+            # depends on which entry point invoked the builder (build vs.
+            # build_preview, sync vs. async wrapping), so a hard-coded
+            # ``stacklevel`` is brittle; ``warn_at_caller`` walks past every
+            # ``data_designer.*`` frame regardless of chain shape. Library
+            # attribution would also be silenced under Python's default
+            # ``ignore::DeprecationWarning`` filter. See PR #594 review.
+            warn_at_caller(msg, DeprecationWarning)
             return False
         return True
 

packages/data-designer-engine/tests/engine/dataset_builders/test_async_builder_integration.py

@@ -101,6 +101,14 @@ def test_resolve_async_compatibility(configs: list[Mock], expected: bool) -> Non
         assert len(w) == 1
         assert issubclass(w[0].category, DeprecationWarning)
         assert "allow_resize" in str(w[0].message)
+        # Regression for PR #594 review: the warning must attribute to the
+        # caller's frame (this test file), not to a ``data_designer.*`` library
+        # frame. Library-attributed ``DeprecationWarning`` entries fall under
+        # Python's default ``ignore::DeprecationWarning`` filter and are
+        # silenced. A regression to ``warnings.warn(..., stacklevel=N)`` would
+        # land somewhere inside the engine package and silently break the
+        # user-facing nudge.
+        assert w[0].filename == __file__
     else:
         assert len(w) == 0
 

packages/data-designer/src/data_designer/cli/controllers/provider_controller.py

@@ -5,7 +5,6 @@
 
 import copy
 import re
-import warnings
 from pathlib import Path
 from typing import TYPE_CHECKING
 
@@ -28,6 +27,7 @@
     print_warning,
     select_with_arrows,
 )
+from data_designer.config.utils.warning_helpers import warn_at_caller
 
 if TYPE_CHECKING:
     from data_designer.engine.model_provider import ModelProvider
@@ -295,7 +295,15 @@ def _handle_change_default(self) -> None:
             "instead of relying on a registry-level default. See issue #589."
         )
         print_warning(deprecation_msg)
-        warnings.warn(deprecation_msg, DeprecationWarning, stacklevel=2)
+        # ``print_warning`` always shows the user the message in the console,
+        # but ``warnings.warn`` is what's observable to programmatic callers
+        # (``pytest.warns``, ``filterwarnings("error", ...)``). With
+        # ``stacklevel=2`` attribution lands on the menu dispatcher in this
+        # same module — a ``data_designer.cli.*`` frame — and Python's default
+        # ``ignore::DeprecationWarning`` filter silences it. ``warn_at_caller``
+        # walks past every ``data_designer.*`` frame so the warning attributes
+        # to the user's call site and stays visible. See PR #594 review.
+        warn_at_caller(deprecation_msg, DeprecationWarning)
         console.print()
 
         providers = self.service.list_all()

packages/data-designer/src/data_designer/cli/repositories/provider_repository.py

@@ -3,7 +3,6 @@
 
 from __future__ import annotations
 
-import warnings
 from pathlib import Path
 
 from pydantic import BaseModel
@@ -12,6 +11,7 @@
 from data_designer.config.models import ModelProvider
 from data_designer.config.utils.constants import MODEL_PROVIDERS_FILE_NAME
 from data_designer.config.utils.io_helpers import load_config_file, save_config_file
+from data_designer.config.utils.warning_helpers import warn_at_caller
 
 
 class ModelProviderRegistry(BaseModel):
@@ -43,14 +43,17 @@ def load(self) -> ModelProviderRegistry | None:
         # ``DeprecationWarning`` is an ``Exception`` subclass, so under
         # ``filterwarnings("error", DeprecationWarning)`` a warn raised inside
         # the catch-all would be silently swallowed and ``load`` would drop the
-        # registry. See PR #594 review.
+        # registry. ``warn_at_caller`` (rather than ``warnings.warn(stacklevel=2)``)
+        # so the warning attributes to the user's call site rather than a
+        # ``data_designer.cli.*`` frame; under default Python filters,
+        # library-attributed ``DeprecationWarning`` entries are silenced
+        # (``ignore::DeprecationWarning``). See PR #594 review.
         if config_dict.get("default") is not None:
-            warnings.warn(
+            warn_at_caller(
                 f"The 'default:' key in {self.config_file} is deprecated and will "
                 "be removed in a future release. Remove it and specify provider= "
                 "explicitly on each ModelConfig instead. See issue #589.",
                 DeprecationWarning,
-                stacklevel=2,
             )
 
         try:

packages/data-designer/tests/cli/controllers/test_provider_controller.py

@@ -1,6 +1,7 @@
 # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 
+import warnings
 from pathlib import Path
 from unittest.mock import MagicMock, patch
 
@@ -216,12 +217,29 @@ def test_handle_change_default_emits_deprecation_warning(
     """Regression for #589: entering the 'Change default provider' workflow
     must emit a ``DeprecationWarning`` so users see the migration nudge before
     setting another value that's also slated for removal.
+
+    Also pins the attribution contract from PR #594 review: the warning must
+    land on the caller's frame (this test file), not on a
+    ``data_designer.cli.*`` library frame. Library attribution falls under
+    Python's default ``ignore::DeprecationWarning`` filter and would silently
+    suppress the user-facing nudge for any caller that isn't using
+    ``simplefilter("always")``.
     """
     mock_select.side_effect = ["change_default", "test-provider-2"]
 
-    with pytest.warns(DeprecationWarning, match="'Change default provider' workflow is deprecated"):
+    with warnings.catch_warnings(record=True) as caught:
+        warnings.simplefilter("always")
         controller_with_providers.run()
 
+    deprecations = [
+        w
+        for w in caught
+        if issubclass(w.category, DeprecationWarning)
+        and "'Change default provider' workflow is deprecated" in str(w.message)
+    ]
+    assert len(deprecations) == 1
+    assert deprecations[0].filename == __file__
+
 
 @patch("data_designer.cli.controllers.provider_controller.confirm_action", return_value=False)
 @patch("data_designer.cli.controllers.provider_controller.select_with_arrows")

packages/data-designer/tests/cli/repositories/test_provider_repository.py

@@ -67,6 +67,34 @@ def test_load_with_yaml_default_emits_deprecation_warning(
     assert registry.default == stub_model_providers[0].name
 
 
+def test_load_with_yaml_default_attributes_warning_to_caller(
+    tmp_path: Path, stub_model_providers: list[ModelProvider]
+) -> None:
+    """Regression for PR #594 review: the YAML-default ``DeprecationWarning``
+    must attribute to the *caller's* frame (this test file), not to a
+    ``data_designer.cli.*`` library frame. Library-attributed
+    ``DeprecationWarning`` entries fall under Python's default
+    ``ignore::DeprecationWarning`` filter and are silenced, so attribution at
+    a library frame == invisible warning. ``warn_at_caller`` keeps this
+    visible; a regression to ``warnings.warn(stacklevel=2)`` would land on
+    ``provider_repository.py`` and silently break the user nudge.
+    """
+    providers_file_path = tmp_path / MODEL_PROVIDERS_FILE_NAME
+    save_config_file(
+        providers_file_path,
+        ModelProviderRegistry(providers=stub_model_providers, default=stub_model_providers[0].name).model_dump(),
+    )
+    repository = ProviderRepository(tmp_path)
+
+    with warnings.catch_warnings(record=True) as caught:
+        warnings.simplefilter("always")
+        repository.load()
+
+    deprecations = [w for w in caught if issubclass(w.category, DeprecationWarning)]
+    assert len(deprecations) == 1
+    assert deprecations[0].filename == __file__
+
+
 def test_load_without_yaml_default_does_not_warn(tmp_path: Path, stub_model_providers: list[ModelProvider]) -> None:
     """Pin the post-deprecation happy path: a YAML without a ``default:`` key
     must load cleanly with no ``DeprecationWarning``.