hide plugin catalog cache ttl

Author: johnnygreco

packages/data-designer/src/data_designer/cli/README.md

@@ -274,7 +274,6 @@ catalogs:
   - alias: research
     url: https://raw.githubusercontent.com/acme/dd-plugins/main/catalog/plugins.json
     trusted: false
-    cache_ttl_seconds: 86400
 ```
 
 ### `~/.data-designer/plugin-catalog-cache/`

packages/data-designer/src/data_designer/cli/commands/plugin.py

@@ -218,12 +218,6 @@ def catalog_add_command(
         "--trusted",
         help="Mark the catalog as trusted for install-plan display and confirmations.",
     ),
-    cache_ttl_seconds: int = typer.Option(
-        24 * 60 * 60,
-        "--cache-ttl-seconds",
-        min=0,
-        help="Seconds before cached catalog metadata is refreshed. Use 0 to always refresh.",
-    ),
 ) -> None:
     """Add a plugin catalog alias."""
     _warn_if_parent_catalog_unused(ctx, "catalog management commands operate on aliases directly")
@@ -232,7 +226,6 @@ def catalog_add_command(
         alias=alias,
         url=url,
         trusted=trusted,
-        cache_ttl_seconds=cache_ttl_seconds,
     )
 
 

packages/data-designer/src/data_designer/cli/controllers/plugin_catalog_controller.py

@@ -323,14 +323,12 @@ def run_catalog_list(self) -> None:
         table.add_column("Alias", style=NordColor.NORD14.value, no_wrap=True)
         table.add_column("URL", style=NordColor.NORD4.value)
         table.add_column("Trusted", style=NordColor.NORD13.value, justify="center")
-        table.add_column("Cache TTL", style=NordColor.NORD9.value, justify="right")
 
         for catalog in catalogs:
             table.add_row(
                 catalog.alias,
                 catalog.url,
                 "yes" if catalog.trusted else "no",
-                f"{catalog.cache_ttl_seconds}s",
             )
         console.print(table)
 
@@ -340,15 +338,13 @@ def run_catalog_add(
         alias: str,
         url: str,
         trusted: bool,
-        cache_ttl_seconds: int,
     ) -> None:
         """Add a plugin catalog alias."""
         try:
             catalog = self.catalog_service.add_catalog(
                 alias,
                 url,
                 trusted=trusted,
-                cache_ttl_seconds=cache_ttl_seconds,
             )
         except ValidationError as e:
             if any(tuple(error["loc"]) == ("alias",) for error in e.errors()):

packages/data-designer/src/data_designer/cli/repositories/plugin_catalog_repository.py

@@ -59,7 +59,7 @@ def load(self) -> PluginCatalogRegistry | None:
 
     def save(self, config: PluginCatalogRegistry) -> None:
         """Save user-configured plugin catalogs."""
-        config_dict = config.model_dump(mode="json", exclude_none=True)
+        config_dict = config.model_dump(mode="json", exclude_none=True, exclude_defaults=True)
         save_config_file(self.config_file, config_dict)
 
     def list_catalogs(self) -> list[PluginCatalogConfig]:

packages/data-designer/src/data_designer/cli/services/plugin_catalog_service.py

@@ -148,14 +148,12 @@ def add_catalog(
         url: str,
         *,
         trusted: bool,
-        cache_ttl_seconds: int,
     ) -> PluginCatalogConfig:
         """Add a plugin catalog alias."""
         return self.repository.add_catalog(
             alias,
             url,
             trusted=trusted,
-            cache_ttl_seconds=cache_ttl_seconds,
         )
 
     def remove_catalog(self, alias: str) -> None:

packages/data-designer/tests/cli/commands/test_plugin_command.py

@@ -128,8 +128,6 @@ def test_plugin_catalog_add_command_delegates_to_controller(mock_ctrl_cls: Magic
             "research",
             "https://github.com/acme/dd-plugins",
             "--trusted",
-            "--cache-ttl-seconds",
-            "60",
         ],
     )
 
@@ -138,7 +136,6 @@ def test_plugin_catalog_add_command_delegates_to_controller(mock_ctrl_cls: Magic
         alias="research",
         url="https://github.com/acme/dd-plugins",
         trusted=True,
-        cache_ttl_seconds=60,
     )
 
 

packages/data-designer/tests/cli/controllers/test_plugin_catalog_controller.py

@@ -615,7 +615,6 @@ def test_run_catalog_add_wraps_invalid_alias_validation_error(
             alias="foo/bar",
             url="https://github.com/acme/dd-plugins",
             trusted=False,
-            cache_ttl_seconds=60,
         )
 
     assert exc_info.value.exit_code == 1

packages/data-designer/tests/cli/repositories/test_plugin_catalog_repository.py

@@ -52,6 +52,17 @@ def test_add_catalog_normalizes_github_repository_url(tmp_path: Path) -> None:
     assert repository.get_catalog("research") == catalog
 
 
+def test_add_catalog_persists_only_public_catalog_fields(tmp_path: Path) -> None:
+    repository = PluginCatalogRepository(tmp_path)
+
+    repository.add_catalog("research", "https://github.com/acme/dd-plugins")
+
+    saved_registry = repository.config_file.read_text()
+    assert "alias: research" in saved_registry
+    assert "url: https://raw.githubusercontent.com/acme/dd-plugins/main/catalog/plugins.json" in saved_registry
+    assert "cache_ttl_seconds" not in saved_registry
+
+
 def test_add_catalog_normalizes_github_tree_url_with_subdirectory(tmp_path: Path) -> None:
     repository = PluginCatalogRepository(tmp_path)