remove plugin catalog trust flag

Author: johnnygreco

packages/data-designer/src/data_designer/cli/README.md

@@ -273,7 +273,6 @@ staging.
 catalogs:
   - alias: research
     url: https://raw.githubusercontent.com/acme/dd-plugins/main/catalog/plugins.json
-    trusted: false
 ```
 
 ### `~/.data-designer/plugin-catalog-cache/`

packages/data-designer/src/data_designer/cli/commands/plugin.py

@@ -213,19 +213,13 @@ def catalog_add_command(
     url: str = typer.Argument(
         help="Catalog repository URL, catalog URL, local catalog file, or local catalog directory."
     ),
-    trusted: bool = typer.Option(
-        False,
-        "--trusted",
-        help="Mark the catalog as trusted for install-plan display and confirmations.",
-    ),
 ) -> None:
     """Add a plugin catalog alias."""
     _warn_if_parent_catalog_unused(ctx, "catalog management commands operate on aliases directly")
     controller = PluginCatalogController(DATA_DESIGNER_HOME)
     controller.run_catalog_add(
         alias=alias,
         url=url,
-        trusted=trusted,
     )
 
 

packages/data-designer/src/data_designer/cli/controllers/plugin_catalog_controller.py

@@ -207,12 +207,6 @@ def run_install(
         if plan.source_warning is not None:
             print_warning(plan.source_warning)
 
-        if not catalog.trusted:
-            print_warning(
-                "This catalog is not marked trusted. Plugin package installation executes Python package code from "
-                "the requirement above."
-            )
-
         if dry_run:
             if not compatibility.is_compatible:
                 print_warning(
@@ -322,13 +316,11 @@ def run_catalog_list(self) -> None:
         table = Table(title="Plugin Catalogs", border_style=NordColor.NORD8.value)
         table.add_column("Alias", style=NordColor.NORD14.value, no_wrap=True)
         table.add_column("URL", style=NordColor.NORD4.value)
-        table.add_column("Trusted", style=NordColor.NORD13.value, justify="center")
 
         for catalog in catalogs:
             table.add_row(
                 catalog.alias,
                 catalog.url,
-                "yes" if catalog.trusted else "no",
             )
         console.print(table)
 
@@ -337,14 +329,12 @@ def run_catalog_add(
         *,
         alias: str,
         url: str,
-        trusted: bool,
     ) -> None:
         """Add a plugin catalog alias."""
         try:
             catalog = self.catalog_service.add_catalog(
                 alias,
                 url,
-                trusted=trusted,
             )
         except ValidationError as e:
             if any(tuple(error["loc"]) == ("alias",) for error in e.errors()):

packages/data-designer/src/data_designer/cli/plugin_catalog.py

@@ -185,7 +185,6 @@ class PluginCatalogConfig(BaseModel):
 
     alias: str = Field(pattern=PLUGIN_CATALOG_ALIAS_PATTERN)
     url: str
-    trusted: bool = False
     cache_ttl_seconds: int = Field(default=PLUGIN_CATALOG_DEFAULT_CACHE_TTL_SECONDS, ge=0)
 
 
@@ -221,7 +220,6 @@ class InstallPlan:
     command: list[str]
     manager: str
     catalog_alias: str
-    trusted_catalog: bool
     source_warning: str | None = None
     data_designer_protection: str | None = None
     command_stdin: str | None = None
@@ -428,7 +426,7 @@ def _validate_catalog_object_keys(context: str, value: dict[str, object], expect
     keys = set(value)
     if keys != expected_keys:
         # Catalog v2 is strict by design: additive wire-schema changes should bump
-        # schema_version so older CLIs do not silently ignore trust-sensitive fields.
+        # schema_version so older CLIs do not silently ignore new fields.
         raise PluginCatalogError(
             f"{context} has invalid fields; expected {{{_format_catalog_keys(expected_keys)}}}, "
             f"got {{{_format_catalog_keys(keys)}}}"

packages/data-designer/src/data_designer/cli/repositories/plugin_catalog_repository.py

@@ -16,7 +16,6 @@
 
 from data_designer.cli.plugin_catalog import (
     DEFAULT_PLUGIN_CATALOG_ALIAS,
-    DEFAULT_PLUGIN_CATALOG_URL,
     MAX_PLUGIN_CATALOG_SIZE_BYTES,
     PLUGIN_CATALOG_CACHE_DIR_NAME,
     PLUGIN_CATALOG_DEFAULT_CACHE_TTL_SECONDS,
@@ -80,7 +79,6 @@ def add_catalog(
         alias: str,
         url: str,
         *,
-        trusted: bool = False,
         cache_ttl_seconds: int = PLUGIN_CATALOG_DEFAULT_CACHE_TTL_SECONDS,
     ) -> PluginCatalogConfig:
         """Persist a new catalog alias.
@@ -94,7 +92,6 @@ def add_catalog(
         catalog = PluginCatalogConfig(
             alias=alias,
             url=normalize_catalog_location(url),
-            trusted=trusted,
             cache_ttl_seconds=cache_ttl_seconds,
         )
         registry = self.load() or PluginCatalogRegistry()
@@ -235,7 +232,6 @@ def default_catalog() -> PluginCatalogConfig:
         return PluginCatalogConfig(
             alias=DEFAULT_PLUGIN_CATALOG_ALIAS,
             url=catalog_url,
-            trusted=catalog_url == DEFAULT_PLUGIN_CATALOG_URL,
             cache_ttl_seconds=PLUGIN_CATALOG_DEFAULT_CACHE_TTL_SECONDS,
         )
 

packages/data-designer/src/data_designer/cli/services/plugin_catalog_service.py

@@ -146,14 +146,11 @@ def add_catalog(
         self,
         alias: str,
         url: str,
-        *,
-        trusted: bool,
     ) -> PluginCatalogConfig:
         """Add a plugin catalog alias."""
         return self.repository.add_catalog(
             alias,
             url,
-            trusted=trusted,
         )
 
     def remove_catalog(self, alias: str) -> None:

packages/data-designer/src/data_designer/cli/services/plugin_install_service.py

@@ -104,7 +104,6 @@ def build_install_plan(
             command=command,
             manager=target.manager,
             catalog_alias=catalog.alias,
-            trusted_catalog=catalog.trusted,
             source_warning=_combine_warnings(target.warning, source_warning),
             data_designer_protection=data_designer_protection,
             command_stdin=command_stdin,

packages/data-designer/tests/cli/commands/test_plugin_command.py

@@ -127,15 +127,13 @@ def test_plugin_catalog_add_command_delegates_to_controller(mock_ctrl_cls: Magic
             "add",
             "research",
             "https://github.com/acme/dd-plugins",
-            "--trusted",
         ],
     )
 
     assert result.exit_code == 0
     mock_ctrl.run_catalog_add.assert_called_once_with(
         alias="research",
         url="https://github.com/acme/dd-plugins",
-        trusted=True,
     )
 
 

packages/data-designer/tests/cli/controllers/test_plugin_catalog_controller.py

@@ -42,7 +42,7 @@ def test_run_list_mentions_hidden_incompatible_packages_when_visible_list_is_emp
     controller: PluginCatalogController,
 ) -> None:
     entry = _entry()
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.list_entries.side_effect = [[], [entry]]
 
@@ -69,7 +69,7 @@ def test_run_search_mentions_hidden_incompatible_packages_when_visible_matches_a
     controller: PluginCatalogController,
 ) -> None:
     entry = _entry()
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.search_entries.side_effect = [[], [entry]]
 
@@ -95,7 +95,7 @@ def test_run_list_renders_package_first_catalog_table(
         _entry(name="text-column", plugin_type="column-generator"),
         _entry(name="text-processor", plugin_type="processor"),
     ]
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.list_entries.return_value = package_entries
     controller.catalog_service.group_entries_by_package.return_value = {
@@ -148,7 +148,7 @@ def test_run_info_renders_package_metadata_with_nested_runtime_plugins(
         _entry(name="text-column", plugin_type="column-generator"),
         _entry(name="text-processor", plugin_type="processor"),
     ]
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.get_package_entries.return_value = package_entries
     controller.catalog_service.evaluate_compatibility.return_value = CompatibilityResult(True, [])
@@ -209,7 +209,7 @@ def test_run_info_warns_when_install_plan_has_source_warning(
     controller: PluginCatalogController,
 ) -> None:
     entry = _entry()
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.get_package_entries.return_value = [entry]
     controller.catalog_service.evaluate_compatibility.return_value = CompatibilityResult(True, [])
@@ -230,7 +230,7 @@ def test_run_info_rejects_runtime_plugin_name_that_is_not_package_alias(
     mock_print_error: MagicMock,
     controller: PluginCatalogController,
 ) -> None:
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.get_package_entries.return_value = []
 
@@ -255,7 +255,7 @@ def test_run_install_dry_run_renders_plan_without_installing(
     controller: PluginCatalogController,
 ) -> None:
     entry = _entry()
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     plan = _plan(catalog, data_designer_protection="pinned installed Data Designer packages; data-designer 0.5.10")
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.get_package_entries.return_value = [entry]
@@ -288,7 +288,7 @@ def test_run_install_blocks_incompatible_package(
     controller: PluginCatalogController,
 ) -> None:
     entry = _entry()
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.get_package_entries.return_value = [entry]
     controller.catalog_service.evaluate_compatibility.return_value = CompatibilityResult(
@@ -318,7 +318,7 @@ def test_run_install_rejects_runtime_plugin_name_as_target(
     mock_print_error: MagicMock,
     controller: PluginCatalogController,
 ) -> None:
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.get_package_entries.return_value = []
 
@@ -344,7 +344,7 @@ def test_run_install_dry_run_renders_incompatible_plan_and_block_message(
     controller: PluginCatalogController,
 ) -> None:
     entry = _entry()
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.get_package_entries.return_value = [entry]
     controller.catalog_service.evaluate_compatibility.return_value = CompatibilityResult(
@@ -376,7 +376,7 @@ def test_run_install_dry_run_allows_incompatible_entry_for_inspection(
     controller: PluginCatalogController,
 ) -> None:
     entry = _entry()
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.get_package_entries.return_value = [entry]
     controller.catalog_service.evaluate_compatibility.return_value = CompatibilityResult(
@@ -410,7 +410,7 @@ def test_run_install_warns_when_install_plan_has_source_warning(
     controller: PluginCatalogController,
 ) -> None:
     entry = _entry()
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.get_package_entries.return_value = [entry]
     controller.catalog_service.evaluate_compatibility.return_value = CompatibilityResult(True, [])
@@ -425,29 +425,6 @@ def test_run_install_warns_when_install_plan_has_source_warning(
     assert mock_console.print.call_count >= 1
 
 
-@patch("data_designer.cli.controllers.plugin_catalog_controller.console")
-@patch("data_designer.cli.controllers.plugin_catalog_controller.print_warning")
-def test_run_install_warns_for_untrusted_catalog(
-    mock_print_warning: MagicMock,
-    mock_console: MagicMock,
-    controller: PluginCatalogController,
-) -> None:
-    entry = _entry()
-    catalog = _catalog(trusted=False)
-    controller.catalog_service.get_catalog.return_value = catalog
-    controller.catalog_service.get_package_entries.return_value = [entry]
-    controller.catalog_service.evaluate_compatibility.return_value = CompatibilityResult(True, [])
-    controller.install_service.build_install_plan.return_value = _plan(catalog)
-
-    controller.run_install("data-designer-text-transform", catalog_alias="local", dry_run=True)
-
-    mock_print_warning.assert_called_once_with(
-        "This catalog is not marked trusted. Plugin package installation executes Python package code from "
-        "the requirement above."
-    )
-    assert mock_console.print.call_count >= 1
-
-
 @patch("data_designer.cli.controllers.plugin_catalog_controller.console")
 @patch("data_designer.cli.controllers.plugin_catalog_controller.print_success")
 def test_run_install_reports_success_when_verification_finds_entry_point(
@@ -456,7 +433,7 @@ def test_run_install_reports_success_when_verification_finds_entry_point(
     controller: PluginCatalogController,
 ) -> None:
     entry = _entry()
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     plan = _plan(catalog)
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.get_package_entries.return_value = [entry]
@@ -482,7 +459,7 @@ def test_run_install_warns_when_verification_misses_entry_point(
     controller: PluginCatalogController,
 ) -> None:
     entry = _entry()
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     plan = _plan(catalog)
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.get_package_entries.return_value = [entry]
@@ -509,7 +486,7 @@ def test_run_uninstall_dry_run_renders_plan_without_uninstalling(
     controller: PluginCatalogController,
 ) -> None:
     entry = _entry()
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     plan = _uninstall_plan(catalog)
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.get_package_entries.return_value = [entry]
@@ -539,7 +516,7 @@ def test_run_uninstall_wraps_plan_error(
     controller: PluginCatalogController,
 ) -> None:
     entry = _entry()
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.get_package_entries.return_value = [entry]
     controller.install_service.build_uninstall_plan.side_effect = ValueError("uv was requested")
@@ -560,7 +537,7 @@ def test_run_uninstall_reports_success_when_entry_points_are_removed(
     controller: PluginCatalogController,
 ) -> None:
     entry = _entry()
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     plan = _uninstall_plan(catalog)
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.get_package_entries.return_value = [entry]
@@ -585,7 +562,7 @@ def test_run_uninstall_warns_when_entry_points_remain(
     controller: PluginCatalogController,
 ) -> None:
     entry = _entry()
-    catalog = _catalog(trusted=True)
+    catalog = _catalog()
     plan = _uninstall_plan(catalog)
     controller.catalog_service.get_catalog.return_value = catalog
     controller.catalog_service.get_package_entries.return_value = [entry]
@@ -614,7 +591,6 @@ def test_run_catalog_add_wraps_invalid_alias_validation_error(
         plugin_controller.run_catalog_add(
             alias="foo/bar",
             url="https://github.com/acme/dd-plugins",
-            trusted=False,
         )
 
     assert exc_info.value.exit_code == 1
@@ -635,11 +611,10 @@ def test_run_catalog_list_wraps_registry_load_error(
     mock_print_error.assert_called_once_with("Failed to list plugin catalogs: bad registry")
 
 
-def _catalog(*, trusted: bool) -> PluginCatalogConfig:
+def _catalog() -> PluginCatalogConfig:
     return PluginCatalogConfig(
         alias="local",
         url="https://raw.githubusercontent.com/acme/dd-plugins/main/catalog/plugins.json",
-        trusted=trusted,
     )
 
 
@@ -655,7 +630,6 @@ def _plan(
         command=["python", "-m", "pip", "install", "data-designer-text-transform"],
         manager="pip",
         catalog_alias=catalog.alias,
-        trusted_catalog=catalog.trusted,
         source_warning=source_warning,
         data_designer_protection=data_designer_protection,
     )