harden plugin CLI test coverage

Author: johnnygreco

packages/data-designer/tests/cli/controllers/test_plugin_catalog_controller.py

@@ -416,6 +416,38 @@ def test_run_info_renders_package_metadata_with_nested_runtime_plugins(
     assert mock_console.print.call_count >= 1
 
 
+@patch("data_designer.cli.controllers.plugin_catalog_controller.print_warning")
+@patch("data_designer.cli.controllers.plugin_catalog_controller.console")
+@patch("data_designer.cli.controllers.plugin_catalog_controller.display_config_preview")
+def test_run_info_still_renders_package_metadata_when_install_plan_cannot_be_built(
+    mock_display_config_preview: MagicMock,
+    mock_console: MagicMock,
+    mock_print_warning: MagicMock,
+    controller: PluginCatalogController,
+) -> None:
+    entry = _entry()
+    catalog = _catalog()
+    controller.catalog_service.get_catalog.return_value = catalog
+    controller.catalog_service.get_package_entries.return_value = [entry]
+    controller.catalog_service.evaluate_compatibility.return_value = CompatibilityResult(True, [])
+    controller.catalog_service.get_package_current_version.return_value = "0.2.0"
+    controller.install_service.build_install_plan.side_effect = ValueError("pip is unavailable")
+
+    controller.run_info("text-transform", catalog_alias="local")
+
+    mock_console.print.assert_any_call("  Version: [bold]0.2.0[/bold]")
+    mock_console.print.assert_any_call("  Runtime plugins: [bold]text-transform (processor)[/bold]")
+    mock_console.print.assert_any_call("  Compatibility: [bold green]data-designer>=0.5.7 ✓[/bold green]")
+    mock_print_warning.assert_called_once_with("pip is unavailable")
+    metadata = mock_display_config_preview.call_args.args[0]
+    assert metadata["package"] == {
+        "name": "data-designer-text-transform",
+        "description": "Transform text records",
+        "version": "0.2.0",
+    }
+    mock_display_config_preview.assert_called_once()
+
+
 @pytest.mark.parametrize(
     ("install_mode", "expected_strategy"),
     [
@@ -874,9 +906,11 @@ def test_run_install_preserves_version_in_runtime_plugin_recovery_hint(
 
 
 @patch("data_designer.cli.controllers.plugin_catalog_controller.console")
+@patch("data_designer.cli.controllers.plugin_catalog_controller.print_error")
 @patch("data_designer.cli.controllers.plugin_catalog_controller.print_warning")
 def test_run_install_dry_run_renders_incompatible_plan_and_block_message(
     mock_print_warning: MagicMock,
+    mock_print_error: MagicMock,
     mock_console: MagicMock,
     controller: PluginCatalogController,
 ) -> None:
@@ -894,9 +928,16 @@ def test_run_install_dry_run_renders_incompatible_plan_and_block_message(
         controller.run_install("data-designer-text-transform", catalog_alias="local", dry_run=True)
 
     assert exc_info.value.exit_code == 1
+    controller.catalog_service.get_package_entries.assert_called_once_with(
+        "data-designer-text-transform",
+        "local",
+        refresh=False,
+        include_incompatible=True,
+    )
     controller.install_service.build_install_plan.assert_called_once_with(entry, catalog, manager="auto")
     controller.install_service.install.assert_not_called()
     controller.install_service.verify_entry_points.assert_not_called()
+    mock_print_error.assert_not_called()
     mock_console.print.assert_any_call("  Install strategy: [bold]pip install[/bold]")
     assert all(
         "Command:" not in str(call_args.args[0]) for call_args in mock_console.print.call_args_list if call_args.args
@@ -911,44 +952,6 @@ def test_run_install_dry_run_renders_incompatible_plan_and_block_message(
     )
 
 
-@patch("data_designer.cli.controllers.plugin_catalog_controller.console")
-@patch("data_designer.cli.controllers.plugin_catalog_controller.print_error")
-@patch("data_designer.cli.controllers.plugin_catalog_controller.print_warning")
-def test_run_install_dry_run_renders_incompatible_entry_for_inspection(
-    mock_print_warning: MagicMock,
-    mock_print_error: MagicMock,
-    mock_console: MagicMock,
-    controller: PluginCatalogController,
-) -> None:
-    entry = _entry(data_designer_requirement="data-designer>=99.0", data_designer_specifier=">=99.0")
-    catalog = _catalog()
-    controller.catalog_service.get_catalog.return_value = catalog
-    controller.catalog_service.get_package_entries.return_value = [entry]
-    controller.catalog_service.evaluate_compatibility.return_value = CompatibilityResult(
-        False,
-        ["Data Designer 0.5.7 does not satisfy >=99.0"],
-    )
-    controller.install_service.build_install_plan.return_value = _plan(catalog)
-
-    with pytest.raises(typer.Exit) as exc_info:
-        controller.run_install("data-designer-text-transform", catalog_alias="local", dry_run=True)
-
-    assert exc_info.value.exit_code == 1
-    controller.catalog_service.get_package_entries.assert_called_once_with(
-        "data-designer-text-transform",
-        "local",
-        refresh=False,
-        include_incompatible=True,
-    )
-    controller.install_service.build_install_plan.assert_called_once_with(entry, catalog, manager="auto")
-    controller.install_service.install.assert_not_called()
-    mock_print_error.assert_not_called()
-    mock_print_warning.assert_called_once_with(
-        "Dry run complete; no changes made. Install would be blocked because compatibility checks failed."
-    )
-    assert mock_console.print.call_count >= 1
-
-
 @patch("data_designer.cli.controllers.plugin_catalog_controller.console")
 @patch("data_designer.cli.controllers.plugin_catalog_controller.print_warning")
 def test_run_install_warns_when_install_plan_has_source_warning(
@@ -1025,6 +1028,32 @@ def test_run_install_warns_when_verification_misses_entry_point(
     assert mock_console.print.call_count >= 1
 
 
+@patch("data_designer.cli.controllers.plugin_catalog_controller.console")
+@patch("data_designer.cli.controllers.plugin_catalog_controller.print_error")
+def test_run_install_wraps_package_manager_failure(
+    mock_print_error: MagicMock,
+    mock_console: MagicMock,
+    controller: PluginCatalogController,
+) -> None:
+    entry = _entry()
+    catalog = _catalog()
+    plan = _plan(catalog)
+    controller.catalog_service.get_catalog.return_value = catalog
+    controller.catalog_service.get_package_entries.return_value = [entry]
+    controller.catalog_service.evaluate_compatibility.return_value = CompatibilityResult(True, [])
+    controller.install_service.build_install_plan.return_value = plan
+    controller.install_service.install.side_effect = RuntimeError("installer exited with status 2")
+
+    with pytest.raises(typer.Exit) as exc_info:
+        controller.run_install("data-designer-text-transform", catalog_alias="local", yes=True)
+
+    assert exc_info.value.exit_code == 1
+    controller.install_service.install.assert_called_once_with(plan)
+    controller.install_service.verify_entry_points.assert_not_called()
+    mock_print_error.assert_called_once_with("installer exited with status 2")
+    assert mock_console.print.call_count >= 1
+
+
 @patch("data_designer.cli.controllers.plugin_catalog_controller.console")
 @patch("data_designer.cli.controllers.plugin_catalog_controller.print_success")
 def test_run_uninstall_dry_run_renders_plan_without_uninstalling(
@@ -1104,6 +1133,31 @@ def test_run_uninstall_wraps_plan_error(
     mock_print_error.assert_called_once_with("Failed to build plugin uninstall plan: uv was requested")
 
 
+@patch("data_designer.cli.controllers.plugin_catalog_controller.console")
+@patch("data_designer.cli.controllers.plugin_catalog_controller.print_error")
+def test_run_uninstall_wraps_package_manager_failure(
+    mock_print_error: MagicMock,
+    mock_console: MagicMock,
+    controller: PluginCatalogController,
+) -> None:
+    entry = _entry()
+    catalog = _catalog()
+    plan = _uninstall_plan(catalog)
+    controller.catalog_service.get_catalog.return_value = catalog
+    controller.catalog_service.get_package_entries.return_value = [entry]
+    controller.install_service.build_uninstall_plan.return_value = plan
+    controller.install_service.uninstall.side_effect = RuntimeError("uninstaller exited with status 2")
+
+    with pytest.raises(typer.Exit) as exc_info:
+        controller.run_uninstall("data-designer-text-transform", catalog_alias="local", yes=True)
+
+    assert exc_info.value.exit_code == 1
+    controller.install_service.uninstall.assert_called_once_with(plan)
+    controller.install_service.verify_entry_points_removed.assert_not_called()
+    mock_print_error.assert_called_once_with("uninstaller exited with status 2")
+    assert mock_console.print.call_count >= 1
+
+
 @patch("data_designer.cli.controllers.plugin_catalog_controller.console")
 @patch("data_designer.cli.controllers.plugin_catalog_controller.print_success")
 def test_run_uninstall_reports_success_when_entry_points_are_removed(

packages/data-designer/tests/cli/repositories/test_plugin_catalog_repository.py

@@ -406,6 +406,80 @@ def test_load_catalog_accepts_equivalent_data_designer_marker_quoting(tmp_path:
     assert catalog.plugins[0].compatibility.data_designer.marker == "python_version < '3.12'"
 
 
+def test_load_catalog_rejects_non_list_packages(tmp_path: Path) -> None:
+    catalog_dir = tmp_path / "catalog"
+    catalog_dir.mkdir()
+    catalog_path = catalog_dir / "plugins.json"
+    catalog_path.write_text(json.dumps({"schema_version": 2, "packages": {"name": "data-designer-bad"}}))
+    repository = PluginCatalogRepository(tmp_path)
+    repository.add_catalog("local", str(catalog_path))
+
+    with pytest.raises(PluginCatalogError, match="catalog document has invalid packages; expected a list"):
+        repository.load_catalog("local", refresh=True)
+
+
+def test_load_catalog_rejects_invalid_runtime_plugin_type(tmp_path: Path) -> None:
+    catalog_path = _write_catalog(
+        tmp_path,
+        packages=[
+            _package_entry(
+                package_name="data-designer-invalid-plugin-type",
+                plugins=[_runtime_plugin("invalid-plugin-type", plugin_type="unknown-type")],
+            )
+        ],
+    )
+    repository = PluginCatalogRepository(tmp_path)
+    repository.add_catalog("local", str(catalog_path))
+
+    with pytest.raises(PluginCatalogError, match="plugin_type 'unknown-type' is invalid"):
+        repository.load_catalog("local", refresh=True)
+
+
+def test_load_catalog_rejects_invalid_entry_point_group(tmp_path: Path) -> None:
+    runtime_plugin = _runtime_plugin("invalid-entry-point-group")
+    runtime_plugin["entry_point"]["group"] = "other.plugins"
+    catalog_path = _write_catalog(
+        tmp_path,
+        packages=[
+            _package_entry(
+                package_name="data-designer-invalid-entry-point-group",
+                plugins=[runtime_plugin],
+            )
+        ],
+    )
+    repository = PluginCatalogRepository(tmp_path)
+    repository.add_catalog("local", str(catalog_path))
+
+    with pytest.raises(PluginCatalogError, match="entry_point.group 'other.plugins' is invalid"):
+        repository.load_catalog("local", refresh=True)
+
+
+def test_load_catalog_rejects_mismatched_data_designer_requirement_specifier(tmp_path: Path) -> None:
+    package = _package_entry()
+    package["compatibility"]["data_designer"] = {
+        "requirement": "data-designer>=0.5.7",
+        "specifier": ">=0.6.0",
+        "marker": None,
+    }
+    catalog_path = _write_catalog(tmp_path, packages=[package])
+    repository = PluginCatalogRepository(tmp_path)
+    repository.add_catalog("local", str(catalog_path))
+
+    with pytest.raises(PluginCatalogError, match="expected '>=0.5.7' from requirement"):
+        repository.load_catalog("local", refresh=True)
+
+
+def test_load_catalog_rejects_non_http_docs_url(tmp_path: Path) -> None:
+    package = _package_entry()
+    package["docs"]["url"] = "ftp://docs.example.test/plugins/data-designer-text-transform/"
+    catalog_path = _write_catalog(tmp_path, packages=[package])
+    repository = PluginCatalogRepository(tmp_path)
+    repository.add_catalog("local", str(catalog_path))
+
+    with pytest.raises(PluginCatalogError, match="expected an absolute HTTP\\(S\\) URL"):
+        repository.load_catalog("local", refresh=True)
+
+
 def test_load_catalog_rejects_invalid_schema_v2_install_metadata(tmp_path: Path) -> None:
     catalog_path = _write_catalog(
         tmp_path,

packages/data-designer/tests/cli/services/test_plugin_install_service.py

@@ -332,6 +332,24 @@ def test_build_auto_install_plan_uses_uv_add_for_non_package_user_project(
     mock_which.assert_called_once_with("uv")
 
 
+@patch("data_designer.cli.services.plugin_install_service.shutil.which", return_value="/usr/bin/uv")
+def test_build_auto_install_plan_uses_uv_add_with_python310_pyproject_fallback(
+    mock_which: Mock,
+    tmp_path: Path,
+) -> None:
+    _write_project(tmp_path)
+    entry = _entry(package_name="data-designer-template", install={"requirement": "data-designer-template"})
+    catalog = PluginCatalogConfig(alias="local", url="/catalog/plugins.json")
+    service = PluginInstallService(working_dir=tmp_path, active_virtualenv=True)
+
+    with patch("data_designer.cli.services.plugin_install_service.tomllib", None):
+        plan = service.build_install_plan(entry, catalog, manager="auto")
+
+    assert plan.install_mode == "uv-project"
+    assert plan.project_root == str(tmp_path)
+    mock_which.assert_called_once_with("uv")
+
+
 @patch("data_designer.cli.services.plugin_install_service.shutil.which", return_value=None)
 def test_build_auto_install_plan_chooses_pip_when_uv_is_unavailable(mock_which: Mock) -> None:
     entry = _entry(package_name="data-designer-template", install={"requirement": "data-designer-template"})
@@ -593,6 +611,73 @@ def test_build_auto_uninstall_plan_skips_uv_remove_when_package_is_not_a_project
     mock_which.assert_called_once_with("uv")
 
 
+@patch("data_designer.cli.services.plugin_install_service.shutil.which", return_value="/usr/bin/uv")
+def test_build_auto_uninstall_plan_detects_project_dependency_with_python310_pyproject_fallback(
+    mock_which: Mock,
+    tmp_path: Path,
+) -> None:
+    _write_project(tmp_path, dependencies=["data-designer-template>=0.1"])
+    entry = _entry(package_name="data-designer-template", install={"requirement": "data-designer-template"})
+    catalog = PluginCatalogConfig(alias="local", url="/catalog/plugins.json")
+    service = PluginInstallService(working_dir=tmp_path, active_virtualenv=True)
+
+    with patch("data_designer.cli.services.plugin_install_service.tomllib", None):
+        plan = service.build_uninstall_plan(entry, catalog, manager="auto")
+
+    assert plan.commands == [
+        [
+            "uv",
+            "remove",
+            "--project",
+            str(tmp_path),
+            "--no-sync",
+            "data-designer-template",
+        ],
+        [
+            "uv",
+            "pip",
+            "uninstall",
+            "--python",
+            sys.executable,
+            "data-designer-template",
+        ],
+    ]
+    assert plan.uninstall_mode == "uv-project"
+    assert plan.project_root == str(tmp_path)
+    mock_which.assert_called_once_with("uv")
+
+
+@patch("data_designer.cli.services.plugin_install_service.shutil.which", return_value="/usr/bin/uv")
+def test_build_auto_uninstall_plan_handles_malformed_python310_pyproject_fallback(
+    mock_which: Mock,
+    tmp_path: Path,
+) -> None:
+    tmp_path.mkdir(exist_ok=True)
+    (tmp_path / "pyproject.toml").write_text(
+        '[project]\nname = "synthetic-data-project"\ndependencies = [not valid\n',
+        encoding="utf-8",
+    )
+    entry = _entry(package_name="data-designer-template", install={"requirement": "data-designer-template"})
+    catalog = PluginCatalogConfig(alias="local", url="/catalog/plugins.json")
+    service = PluginInstallService(working_dir=tmp_path, active_virtualenv=True)
+
+    with patch("data_designer.cli.services.plugin_install_service.tomllib", None):
+        plan = service.build_uninstall_plan(entry, catalog, manager="auto")
+
+    assert plan.command == [
+        "uv",
+        "pip",
+        "uninstall",
+        "--python",
+        sys.executable,
+        "data-designer-template",
+    ]
+    assert plan.commands == [plan.command]
+    assert plan.uninstall_mode == "uv-environment"
+    assert plan.project_root is None
+    mock_which.assert_called_once_with("uv")
+
+
 @patch("data_designer.cli.services.plugin_install_service.shutil.which", return_value="/usr/bin/uv")
 def test_build_uv_install_plan_targets_current_python_and_adds_catalog_index(mock_which: Mock) -> None:
     entry = _entry(