Skip to content

Commit a3e01c1

Browse files
committed
chore: add some sql format unit tests
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
1 parent f50f6b8 commit a3e01c1

1 file changed

Lines changed: 16 additions & 4 deletions

File tree

  • packages/data-designer-engine/tests/engine/validators

packages/data-designer-engine/tests/engine/validators/test_sql.py

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,22 @@
99
from data_designer.config.validator_params import CodeValidatorParams
1010
from data_designer.engine.validators.sql import SQLValidator
1111

12-
13-
def test_valid_ansi_sql_code() -> None:
14-
sql_validator = SQLValidator(CodeValidatorParams(code_lang=CodeLang.SQL_ANSI))
15-
code = "SELECT category, COUNT(*) as total_incidents FROM security_incidents_2 GROUP BY category;"
12+
VALID_SQL_BY_DIALECT = [
13+
(
14+
CodeLang.SQL_ANSI,
15+
"SELECT category, COUNT(*) AS total_incidents FROM security_incidents_2 GROUP BY category;",
16+
),
17+
(CodeLang.SQL_SQLITE, "SELECT sqlite_version() AS version;"),
18+
(CodeLang.SQL_TSQL, "SELECT TOP 1 name FROM sys.objects;"),
19+
(CodeLang.SQL_BIGQUERY, "SELECT * EXCEPT(sensitive_column) FROM `project.dataset.table`;"),
20+
(CodeLang.SQL_MYSQL, "SELECT `name` FROM users LIMIT 1;"),
21+
(CodeLang.SQL_POSTGRES, "SELECT 1::int AS value;"),
22+
]
23+
24+
25+
@pytest.mark.parametrize(("code_lang", "code"), VALID_SQL_BY_DIALECT)
26+
def test_valid_sql_code_for_supported_dialects(code_lang: CodeLang, code: str) -> None:
27+
sql_validator = SQLValidator(CodeValidatorParams(code_lang=code_lang))
1628
result = sql_validator.run_validation([{"sql": code}])
1729
assert result.data[0].is_valid
1830
assert result.data[0].error_messages == ""

0 commit comments

Comments
 (0)