Skip to content

Commit a58efe9

Browse files
committed
fix: address review nits — move datetime import to module scope, drop redundant isinstance
1 parent 3302185 commit a58efe9

File tree

1 file changed

+2
-4
lines changed
  • packages/data-designer-engine/tests/engine/sampling_gen/data_sources

1 file changed

+2
-4
lines changed

packages/data-designer-engine/tests/engine/sampling_gen/data_sources/test_sources.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
from __future__ import annotations
55

6+
from datetime import datetime
67
from unittest.mock import Mock
78

89
import pytest
@@ -166,13 +167,10 @@ def test_datetime_format_mixin_postproc_same_month_records():
166167

167168
def test_datetime_format_mixin_postproc_stdlib_fromisoformat():
168169
"""Output must be parseable by Python stdlib datetime.fromisoformat, not just pandas."""
169-
from datetime import datetime
170-
171170
series = lazy.pd.Series(lazy.pd.to_datetime(["2024-06-15 14:30:00", "2025-01-01 00:00:00"]))
172171
result = DatetimeFormatMixin.postproc(series, None)
173172
for val in result:
174-
parsed = datetime.fromisoformat(val)
175-
assert isinstance(parsed, datetime)
173+
datetime.fromisoformat(val)
176174

177175

178176
def test_datetime_format_mixin_postproc_round_trip_preserves_values():

0 commit comments

Comments
 (0)