Commit e558dd7
fix: document transport param and annotate private attr chains in tests
Address Greptile P2 review comments on PR #460:
- Add docstring entry for the new `transport` parameter in
`create_retry_transport` explaining accepted types and None default
- Add inline comments in pool-size regression tests explaining the
private attribute chain (_sync/_async_transport → _pool → _max_connections)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Przemysław <przemekboruta@interia.pl>1 parent d482067 commit e558dd7
2 files changed
Lines changed: 14 additions & 0 deletions
File tree
- packages/data-designer-engine
- src/data_designer/engine/models/clients
- tests/engine/models/clients
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
59 | 65 | | |
60 | 66 | | |
61 | 67 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
308 | 308 | | |
309 | 309 | | |
310 | 310 | | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
311 | 315 | | |
312 | 316 | | |
313 | 317 | | |
| |||
325 | 329 | | |
326 | 330 | | |
327 | 331 | | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
328 | 336 | | |
329 | 337 | | |
0 commit comments