Skip to content

chore(agentic-ci): add future annotations import to dataset_metadata.py#640

Merged
andreatgretel merged 3 commits into
mainfrom
agentic-ci/chore/structure-20260513-future-dataset-metadata
May 20, 2026
Merged

chore(agentic-ci): add future annotations import to dataset_metadata.py#640
andreatgretel merged 3 commits into
mainfrom
agentic-ci/chore/structure-20260513-future-dataset-metadata

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Summary

Add from __future__ import annotations to
packages/data-designer-config/src/data_designer/config/dataset_metadata.py.

Why

Per AGENTS.md ("Structural Invariants"):

from __future__ import annotations — required in every Python source file.

The structural-integrity audit detected this file as the only source file
under packages/*/src/ missing the import.

What changed

A single line — from __future__ import annotations — inserted after the
SPDX header block and before existing imports. No functional change.

Tests

make test-config — 562 passed.

Provenance

Generated by the agentic-ci structure suite (daily run, 2026-05-13).
Finding id dc0ea67d384e, fix confidence 1.0.

Per AGENTS.md: every Python source file requires
`from __future__ import annotations`.
@github-actions github-actions Bot requested a review from a team as a code owner May 13, 2026 14:41
@github-actions github-actions Bot added agentic-ci Created by agentic-ci automation agentic-ci/structure Structural integrity suite labels May 13, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 13, 2026

Greptile Summary

This PR adds the missing from __future__ import annotations import to dataset_metadata.py, the only file under packages/*/src/ that was lacking it, bringing it in line with the repository's structural invariant.

  • Single-line insertion after the SPDX header block; all annotations in this file (list[str]) remain valid under deferred evaluation with both Pydantic v1 and v2.
  • Automated structural-integrity audit (agentic-ci structure suite) detected and generated this fix; 562 tests passed.

Confidence Score: 5/5

Safe to merge — a single-line import addition with no functional change and a full passing test suite.

The change adds exactly one import line to satisfy a repo-wide structural rule. The existing annotation (list[str]) is compatible with deferred evaluation, and the test run confirms no regressions.

No files require special attention.

Important Files Changed

Filename Overview
packages/data-designer-config/src/data_designer/config/dataset_metadata.py Adds from __future__ import annotations after the SPDX header block to comply with the repo-wide structural invariant; no functional change.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["dataset_metadata.py"] --> B["SPDX Header Comments"]
    B --> C["from __future__ import annotations ✅ (added)"]
    C --> D["from pydantic import BaseModel"]
    D --> E["class DatasetMetadata(BaseModel)"]
    E --> F["seed_column_names: list[str] = []"]
Loading

Reviews (3): Last reviewed commit: "Merge branch 'main' into agentic-ci/chor..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

@eric-tramel eric-tramel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible find agentic-ci 🫡

@github-actions
Copy link
Copy Markdown
Contributor Author

Thank you for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


1 out of 2 committers have signed the DCO.
✅ (andreatgretel)[https://github.com/andreatgretel]
@agentic-ci
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot.

@andreatgretel
Copy link
Copy Markdown
Contributor

/authorize-agentic-ci

@andreatgretel andreatgretel merged commit 383db51 into main May 20, 2026
90 checks passed
@andreatgretel andreatgretel deleted the agentic-ci/chore/structure-20260513-future-dataset-metadata branch May 20, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentic-ci/structure Structural integrity suite agentic-ci Created by agentic-ci automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants