Skip to content
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions .github/workflows/agentic-ci-daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,11 @@ jobs:
| sed "s|{{date}}|$(date -u +%Y-%m-%d)|g" \
| sed "s|{{memory_path}}|.agentic-ci-state|g")

claude \
stdbuf -oL -eL claude \
--model "$AGENTIC_CI_MODEL" \
-p "$PROMPT" \
--max-turns 30 \
--output-format text \
--max-turns 50 \
--output-format stream-json \
--verbose \
2>&1 | tee /tmp/claude-audit-log.txt

Expand All @@ -205,6 +205,17 @@ jobs:
json.dump(state, f, indent=2)
"

- name: Upload agent log
if: failure()
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: claude-audit-log-${{ matrix.suite }}-${{ github.run_id }}-${{ github.run_attempt }}
path: |
/tmp/claude-audit-log.txt
/tmp/audit-${{ matrix.suite }}.md
retention-days: 14
if-no-files-found: ignore

- name: Write job summary
if: always()
env:
Expand All @@ -216,15 +227,5 @@ jobs:
if [ -s "/tmp/audit-${SUITE}.md" ]; then
cat "/tmp/audit-${SUITE}.md" >> "$GITHUB_STEP_SUMMARY"
else
echo "No report generated." >> "$GITHUB_STEP_SUMMARY"
fi

if [ -s "/tmp/claude-audit-log.txt" ]; then
echo "" >> "$GITHUB_STEP_SUMMARY"
echo "<details><summary>Agent log</summary>" >> "$GITHUB_STEP_SUMMARY"
echo "" >> "$GITHUB_STEP_SUMMARY"
echo '```' >> "$GITHUB_STEP_SUMMARY"
tail -100 /tmp/claude-audit-log.txt >> "$GITHUB_STEP_SUMMARY"
echo '```' >> "$GITHUB_STEP_SUMMARY"
echo "</details>" >> "$GITHUB_STEP_SUMMARY"
echo "No report generated. See the \`claude-audit-log-*\` artifact on failures for the full event stream." >> "$GITHUB_STEP_SUMMARY"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Misleading fallback message on success-with-no-report

The new fallback message tells users to check the claude-audit-log-* artifact, but the artifact upload is gated on if: failure(). If the audit step exits successfully yet no /tmp/audit-${SUITE}.md is produced (e.g. the agent ran to completion without writing the report), the summary points to an artifact that was never uploaded.

Suggested change
echo "No report generated. See the \`claude-audit-log-*\` artifact on failures for the full event stream." >> "$GITHUB_STEP_SUMMARY"
echo "No report generated." >> "$GITHUB_STEP_SUMMARY"

Alternatively, the message could be conditioned on the step outcome, but reverting to the neutral original text avoids the false reference entirely.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/agentic-ci-daily.yml
Line: 230

Comment:
**Misleading fallback message on success-with-no-report**

The new fallback message tells users to check the `claude-audit-log-*` artifact, but the artifact upload is gated on `if: failure()`. If the audit step exits successfully yet no `/tmp/audit-${SUITE}.md` is produced (e.g. the agent ran to completion without writing the report), the summary points to an artifact that was never uploaded.

```suggestion
            echo "No report generated." >> "$GITHUB_STEP_SUMMARY"
```

Alternatively, the message could be conditioned on the step outcome, but reverting to the neutral original text avoids the false reference entirely.

How can I resolve this? If you propose a fix, please make it concise.

fi
Loading