Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/data-designer-engine/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ dependencies = [
"python-multipart>=0.0.27,<1", # 0.0.27 fixes security advisory pulled in by mcp
"ruff>=0.14.10,<1",
"scipy>=1.11.0,<2",
"sqlfluff>=3.2.0,<4",
"sqlfluff>=4.1.0,<5",
"tiktoken>=0.8.0,<1",
]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,22 @@
from data_designer.config.validator_params import CodeValidatorParams
from data_designer.engine.validators.sql import SQLValidator


def test_valid_ansi_sql_code() -> None:
sql_validator = SQLValidator(CodeValidatorParams(code_lang=CodeLang.SQL_ANSI))
code = "SELECT category, COUNT(*) as total_incidents FROM security_incidents_2 GROUP BY category;"
VALID_SQL_BY_DIALECT = [
(
CodeLang.SQL_ANSI,
"SELECT category, COUNT(*) AS total_incidents FROM security_incidents_2 GROUP BY category;",
),
(CodeLang.SQL_SQLITE, "SELECT sqlite_version() AS version;"),
(CodeLang.SQL_TSQL, "SELECT TOP 1 name FROM sys.objects;"),
(CodeLang.SQL_BIGQUERY, "SELECT * EXCEPT(sensitive_column) FROM `project.dataset.table`;"),
(CodeLang.SQL_MYSQL, "SELECT `name` FROM users LIMIT 1;"),
(CodeLang.SQL_POSTGRES, "SELECT 1::int AS value;"),
]


@pytest.mark.parametrize(("code_lang", "code"), VALID_SQL_BY_DIALECT)
def test_valid_sql_code_for_supported_dialects(code_lang: CodeLang, code: str) -> None:
sql_validator = SQLValidator(CodeValidatorParams(code_lang=code_lang))
result = sql_validator.run_validation([{"sql": code}])
assert result.data[0].is_valid
assert result.data[0].error_messages == ""
Expand Down
9 changes: 4 additions & 5 deletions uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading