Remove template from public catalog (#45)

Author: eric-tramel

Makefile

@@ -113,7 +113,7 @@ check: check-plugin-docs check-catalog check-package-index check-codeowners chec
 all: lint test validate check docs
 
 # ── Release ─────────────────────────────────────────────────────────────
-# Usage: make release PLUGIN=data-designer-template
+# Usage: make release PLUGIN=data-designer-my-plugin
 
 PLUGIN ?=
 PART ?= patch

catalog/plugins.json

@@ -73,38 +73,6 @@
           }
         }
       ]
-    },
-    {
-      "name": "data-designer-template",
-      "description": "Template Data Designer plugin \u2014 text transform column generator",
-      "install": {
-        "requirement": "data-designer-template",
-        "index_url": "https://nvidia-nemo.github.io/DataDesignerPlugins/simple/"
-      },
-      "compatibility": {
-        "python": {
-          "specifier": ">=3.10"
-        },
-        "data_designer": {
-          "requirement": "data-designer>=0.5.7",
-          "specifier": ">=0.5.7",
-          "marker": null
-        }
-      },
-      "docs": {
-        "url": "https://nvidia-nemo.github.io/DataDesignerPlugins/plugins/data-designer-template/"
-      },
-      "plugins": [
-        {
-          "name": "text-transform",
-          "plugin_type": "column-generator",
-          "entry_point": {
-            "group": "data_designer.plugins",
-            "name": "text-transform",
-            "value": "data_designer_template.plugin:plugin"
-          }
-        }
-      ]
     }
   ]
 }

devtools/ddp/tests/test_catalog.py

@@ -859,3 +859,9 @@ def test_checked_in_nvidia_catalog_uses_static_package_index() -> None:
     assert {
         package["install"]["index_url"] for package in output["packages"] if isinstance(package.get("install"), dict)
     } == {"https://nvidia-nemo.github.io/DataDesignerPlugins/simple/"}
+
+
+def test_checked_in_nvidia_catalog_excludes_template_package() -> None:
+    output = json.loads(catalog.PLUGINS_CATALOG_PATH.read_text(encoding="utf-8"))
+
+    assert "data-designer-template" not in {package["name"] for package in output["packages"]}

devtools/ddp/tests/test_validate_release.py

@@ -328,14 +328,17 @@ def test_release_ref_template_mismatch_fails(tmp_path: Path) -> None:
     assert any("release-ref-template" in error and "release/data-designer-example/0.1.0" in error for error in errors)
 
 
-def test_valid_template_plugin_passes() -> None:
-    """validate_release should pass for the template plugin with its actual version."""
+def test_template_plugin_is_not_publicly_cataloged() -> None:
+    """The reference template should stay out of the public catalog."""
     root = find_repo_root()
+    catalog_document = json.loads((root / "catalog" / "plugins.json").read_text(encoding="utf-8"))
+    assert "data-designer-template" not in {package["name"] for package in catalog_document["packages"]}
+
     data = load_toml(root / "plugins" / "data-designer-template" / "pyproject.toml")
     version = data["project"]["version"]
 
     result = main(["data-designer-template", version])
-    assert result == 0
+    assert result == 1
 
 
 def test_wrong_version_fails() -> None: