PSGD-Kron's helper functions#37
Merged
Merged
Conversation
e2c3b93 to
7b54565
Compare
skyw
requested changes
Oct 7, 2025
8f81cea to
4c13635
Compare
|
@mkhona-nvidia This is really awesome work! The functions are looking accurate. I'll mention these for down the road:
|
2797463 to
b066ed1
Compare
Contributor
Author
|
/ok to test b066ed1 |
Contributor
Author
Sounds good; Once this PR is merged, I will have another PR that actually uses the building blocks of this PR to make PSGD-Kron-Pro with this flow and defaults |
Contributor
Author
|
/ok to test 2062d44 |
Contributor
Author
|
/ok to test 0788dc9 |
…atest code Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
835ab1d to
e5b5ba5
Compare
Signed-off-by: mikail <mkhona@nvidia.com>
Contributor
Author
|
/ok to test 2fe3ce3 |
skyw
previously approved these changes
Oct 8, 2025
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Contributor
Author
|
/ok to test 5006bb9 |
skyw
approved these changes
Oct 8, 2025
pablo-garay
pushed a commit
that referenced
this pull request
Oct 10, 2025
* cleaned up lower bound function for spectral norm based on Xi-lin's latest code Signed-off-by: mikail <mkhona@nvidia.com> Signed-off-by: Pablo Garay <pagaray@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building the helper functions for the PSGD Kron optimizer By Xilin-Li.
Includes subspace-iteration based spectral lower bound calculation, an online procrustes solver and functions to apply the kronecker-factored upper triangular factored preconditioner.