Improve tests for scalar optimizers#39
Merged
Merged
Conversation
skyw
requested changes
Oct 6, 2025
Contributor
|
LGTM. |
mkhona-nvidia
force-pushed
the
mkhona/soap_laprop
branch
from
b5f68de to
2fd6397
Compare
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
mkhona-nvidia
force-pushed
the
mkhona/soap_laprop
branch
from
9c6eaec to
b7fd643
Compare
Contributor
Author
|
/ok to test b7fd643 |
skyw
approved these changes
Oct 6, 2025
mkhona-nvidia
added a commit
to mkhona-nvidia/Emerging-Optimizers
that referenced
this pull request
Oct 7, 2025
* test on both CPU and GPU Signed-off-by: mikail <mkhona@nvidia.com>
mkhona-nvidia
added a commit
to mkhona-nvidia/Emerging-Optimizers
that referenced
this pull request
Oct 7, 2025
* test on both CPU and GPU Signed-off-by: mikail <mkhona@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added flags for scalar optimizer test and improved device handling