docs: genericize PPP terminology and lustre path in launching-evals SKILL#1023
Merged
marta-sd merged 1 commit intoMay 22, 2026
Conversation
The "Key Facts" section of `launching-evals/SKILL.md` had two NVIDIA-internal references that bias the skill toward NVIDIA infra and confuse external users: 1. "PPP" terminology with `coreai_dlalgo_*` example account names. "PPP" is internal NVIDIA jargon; the example values are NVIDIA-specific. Renamed the bullet to "SLURM account" (the universally-correct term) and kept "PPP" as a parenthetical alias so internal users still recognize it. Genericized the example values to `<account_name>` / `<new_account_name>`. 2. The HF cache download example hardcoded an NVIDIA-internal lustre path (`/lustre/fsw/portfolios/coreai/users/<username>/cache/...`). Replaced with `<your_hf_cache_dir>` placeholder, with a hint that it should be a shared filesystem accessible from compute nodes (`/lustre/...` for multi-node, `~/.cache/huggingface` for single-node). Closes NVIDIA-NeMo#938 Signed-off-by: Zhiyu Cheng <zhiyuc@nvidia.com>
Contributor
|
/ok to test 54a7f4d |
marta-sd
approved these changes
May 22, 2026
Contributor
marta-sd
left a comment
There was a problem hiding this comment.
LGTM, thank you @Edwardf0t1 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #938. cc @marta-sd
Summary
The "Key Facts" section of
launching-evals/SKILL.mdhad two NVIDIA-internal references that bias the skill toward NVIDIA infra and confuse external users:"PPP" terminology with
coreai_dlalgo_*example account names. "PPP" is internal NVIDIA jargon; the example values are NVIDIA-specific.<account_name>/<new_account_name>.HF cache download example hardcoded an NVIDIA-internal lustre path (
/lustre/fsw/portfolios/coreai/users/<username>/cache/...).<your_hf_cache_dir>placeholder./lustre/...for multi-node clusters or~/.cache/huggingfacefor single-node setups.Diff
Context
This came up while vendoring
launching-evalsintoNVIDIA/Model-Optimizer(PR #1239). Reviewers flagged the internal references. Issue #938 has the full discussion.Thanks for the earlier gitlab-master URL fix in #920 — this PR addresses the two leftovers.