fix(embeddings): preserve OpenAI import validation

Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>

Author: Pouyanpi

nemoguardrails/embeddings/providers/openai.py

@@ -47,16 +47,15 @@ def __init__(
     ):
         try:
             import openai
-            from openai import OpenAI
-        except ImportError:
-            raise ImportError("Could not import openai, please install it with `pip install openai`.")
+        except ImportError as err:
+            raise ImportError("Could not import openai, please install it with `pip install openai`.") from err
         if openai.__version__ < "1.0.0":
             raise RuntimeError(
                 "`openai<1.0.0` is no longer supported. Please upgrade using `pip install openai>=1.0.0`."
             )
 
         self.model = embedding_model
-        self.client = OpenAI(**kwargs)
+        self.client = openai.OpenAI(**kwargs)
 
         self.embedding_size_dict = {
             "text-embedding-ada-002": 1536,

tests/test_embeddings_providers_mock.py

@@ -14,6 +14,7 @@
 # limitations under the License.
 
 import sys
+from types import ModuleType
 from unittest.mock import MagicMock, Mock, patch
 
 import pytest
@@ -226,7 +227,7 @@ def test_init_with_unknown_model(self):
 
     def test_import_error_when_openai_not_installed(self):
         with patch.dict("sys.modules", {"openai": None}):
-            with pytest.raises(ImportError, match="Could not import openai"):
+            with pytest.raises(ImportError, match="Could not import openai") as exc_info:
                 if "nemoguardrails.embeddings.providers.openai" in sys.modules:
                     del sys.modules["nemoguardrails.embeddings.providers.openai"]
 
@@ -236,8 +237,10 @@ def test_import_error_when_openai_not_installed(self):
 
                 OpenAIEmbeddingModel("text-embedding-3-small")
 
+            assert isinstance(exc_info.value.__cause__, ImportError)
+
     def test_old_version_error(self):
-        mock_openai = MagicMock()
+        mock_openai = ModuleType("openai")
         mock_openai.__version__ = "0.28.0"
 
         with patch.dict("sys.modules", {"openai": mock_openai}):