fix(llmrails): load library files deterministically

Author: Pouyanpi

nemoguardrails/llm/prompts.py

@@ -41,6 +41,8 @@ def _load_prompts() -> List[TaskPrompt]:
 
     for path in prompts_dirs:
         for root, dirs, files in os.walk(path):
+            dirs.sort()
+            files.sort()
             for filename in files:
                 if filename.endswith(".yml") or filename.endswith(".yaml"):
                     with open(os.path.join(root, filename), encoding="utf-8") as prompts_file:

nemoguardrails/rails/llm/llmrails.py

@@ -197,9 +197,13 @@ def __init__(
             self.config.flows.extend(default_flows)
 
             # We also need to load the content from the components library.
+            # Sort entries so the traversal order is filesystem-independent;
+            # otherwise the order in which library bot_messages are inserted
+            # (and which definition wins on collisions) varies between platforms.
             library_path = os.path.join(os.path.dirname(__file__), "../../library")
             for root, dirs, files in os.walk(library_path):
-                for file in files:
+                dirs.sort()
+                for file in sorted(files):
                     # Extract the full path for the file
                     full_path = os.path.join(root, file)
                     if file.endswith(".co"):

tests/test_prompt_override.py

@@ -16,6 +16,7 @@
 import os
 
 from nemoguardrails import RailsConfig
+from nemoguardrails.llm import prompts as prompts_module
 from nemoguardrails.llm.prompts import get_prompt
 from nemoguardrails.llm.types import Task
 
@@ -28,3 +29,18 @@ def test_custom_llm_registration():
     prompt = get_prompt(config, Task.GENERATE_USER_INTENT)
 
     assert prompt.content == "<<This is a placeholder for a custom prompt for generating the user intent>>"
+
+
+def test_load_prompts_sorts_files_for_deterministic_overrides(tmp_path, monkeypatch):
+    prompts_dir = tmp_path / "prompts"
+    prompts_dir.mkdir()
+    (prompts_dir / "z.yml").write_text("prompts:\n- task: generate_user_intent\n  content: z\n", encoding="utf-8")
+    (prompts_dir / "a.yml").write_text("prompts:\n- task: generate_user_intent\n  content: a\n", encoding="utf-8")
+
+    def walk(_path):
+        yield str(prompts_dir), [], ["z.yml", "a.yml"]
+
+    monkeypatch.setattr(prompts_module, "CURRENT_DIR", str(tmp_path))
+    monkeypatch.setattr(prompts_module.os, "walk", walk)
+
+    assert [prompt.content for prompt in prompts_module._load_prompts()] == ["a", "z"]