fix(types): require id field on tool calls in ChatMessage.from_dict (#1775)

Author: Pouyanpi

nemoguardrails/types.py

@@ -164,9 +164,13 @@ def from_dict(cls, d: Dict[str, Any]) -> "ChatMessage":
                         )
                     args_dict = raw_args
 
+                tc_id = tc.get("id")
+                if not tc_id:
+                    raise ValueError("Tool call missing required 'id' field.")
+
                 tool_calls.append(
                     ToolCall(
-                        id=tc.get("id", ""),
+                        id=tc_id,
                         type=tc.get("type", "function"),
                         function=ToolCallFunction(
                             name=func_data.get("name", ""),

tests/test_types.py

@@ -258,6 +258,22 @@ def test_from_dict_with_legacy_flat_tool_calls(self):
         assert msg.tool_calls[0].function.arguments == {"q": "x"}
         assert msg.tool_calls[0].id == "tc_1"
 
+    def test_from_dict_raises_on_tool_call_missing_id(self):
+        d = {
+            "role": "assistant",
+            "tool_calls": [{"function": {"name": "search", "arguments": {"q": "x"}}}],
+        }
+        with pytest.raises(ValueError, match="missing required 'id'"):
+            ChatMessage.from_dict(d)
+
+    def test_from_dict_raises_on_tool_call_empty_id(self):
+        d = {
+            "role": "assistant",
+            "tool_calls": [{"id": "", "function": {"name": "search", "arguments": {"q": "x"}}}],
+        }
+        with pytest.raises(ValueError, match="missing required 'id'"):
+            ChatMessage.from_dict(d)
+
     def test_from_dict_captures_provider_metadata(self):
         d = {"role": "user", "content": "hi", "provider_metadata": {"custom_field": "value", "model": "gpt-4"}}
         msg = ChatMessage.from_dict(d)