fix(build): remove chat-ui references from wheel build script#1835
fix(build): remove chat-ui references from wheel build script#1835
Conversation
The chat-ui directory was removed in #1734 (Chatbot UI replaced by Chainlit), but .github/scripts/build.sh still tried to copy it into the package before running poetry build, causing the publish workflow to fail with "cannot stat 'chat-ui'". Drop the CHAT_UI_SRC/DST variables and the corresponding cp/rm lines so the wheel build only copies the still-existing examples directory. Resolves the failure at https://github.com/NVIDIA-NeMo/Guardrails/actions/runs/25082804479
Greptile SummaryThis PR removes four dead lines from
|
| Filename | Overview |
|---|---|
| .github/scripts/build.sh | Removes the four lines referencing the deleted chat-ui directory (variables, cp, rm); the remaining examples copy-and-clean logic is unchanged and correct. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[build.sh starts] --> B["cp -r examples → nemoguardrails/examples"]
B --> C[poetry build]
C --> D["rm -rf nemoguardrails/examples"]
D --> E[Done]
style A fill:#f0f0f0
style E fill:#d4edda
Reviews (3): Last reviewed commit: "fix(build): remove chat-ui references fr..." | Re-trigger Greptile
📝 WalkthroughWalkthroughThe build script removes Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
9067913 to
5ff36c8
Compare
Description
The chat-ui directory was removed in #1734 (Chatbot UI replaced by Chainlit), but .github/scripts/build.sh still tried to copy it into the package before running poetry build, causing the publish workflow to fail with "cannot stat 'chat-ui'".
Drop the CHAT_UI_SRC/DST variables and the corresponding cp/rm lines so the wheel build only copies the still-existing examples directory.
Resolves the failure at
https://github.com/NVIDIA-NeMo/Guardrails/actions/runs/25082804479
Test Plan
failed at
https://github.com/NVIDIA-NeMo/Guardrails/actions/runs/25082804479
passed at:
https://github.com/NVIDIA-NeMo/Guardrails/actions/runs/25104043497
Summary by CodeRabbit