Skip to content

fix(build): remove chat-ui references from wheel build script#1835

Merged
Pouyanpi merged 1 commit intodevelopfrom
fix/build-script-remove-chat-ui
Apr 30, 2026
Merged

fix(build): remove chat-ui references from wheel build script#1835
Pouyanpi merged 1 commit intodevelopfrom
fix/build-script-remove-chat-ui

Conversation

@Pouyanpi
Copy link
Copy Markdown
Collaborator

@Pouyanpi Pouyanpi commented Apr 29, 2026

Description

The chat-ui directory was removed in #1734 (Chatbot UI replaced by Chainlit), but .github/scripts/build.sh still tried to copy it into the package before running poetry build, causing the publish workflow to fail with "cannot stat 'chat-ui'".

Drop the CHAT_UI_SRC/DST variables and the corresponding cp/rm lines so the wheel build only copies the still-existing examples directory.

Resolves the failure at
https://github.com/NVIDIA-NeMo/Guardrails/actions/runs/25082804479

Test Plan

failed at
https://github.com/NVIDIA-NeMo/Guardrails/actions/runs/25082804479
passed at:
https://github.com/NVIDIA-NeMo/Guardrails/actions/runs/25104043497

Summary by CodeRabbit

  • Chores
    • Streamlined the build packaging workflow by removing unnecessary steps from the build script, resulting in a cleaner and more efficient build process.

The chat-ui directory was removed in #1734 (Chatbot UI replaced by
Chainlit), but .github/scripts/build.sh still tried to copy it into
the package before running poetry build, causing the publish workflow
to fail with "cannot stat 'chat-ui'".

Drop the CHAT_UI_SRC/DST variables and the corresponding cp/rm lines
so the wheel build only copies the still-existing examples directory.

Resolves the failure at
https://github.com/NVIDIA-NeMo/Guardrails/actions/runs/25082804479
@Pouyanpi Pouyanpi self-assigned this Apr 29, 2026
@Pouyanpi Pouyanpi added the CI label Apr 29, 2026
@Pouyanpi Pouyanpi added this to the v0.22.0 milestone Apr 29, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 29, 2026

Greptile Summary

This PR removes four dead lines from .github/scripts/build.sh that referenced the chat-ui directory deleted in #1734. With those lines gone, the publish workflow no longer fails on the missing chat-ui source; the only remaining side-effect (copying/removing examples) is unchanged.

Confidence Score: 5/5

Safe to merge — targeted removal of stale references with no functional risk.

Single-file, four-line deletion that removes references to a directory confirmed absent from the repo. No logic changes, no new code paths, and the CI run linked in the PR description confirms the fix works.

No files require special attention.

Important Files Changed

Filename Overview
.github/scripts/build.sh Removes the four lines referencing the deleted chat-ui directory (variables, cp, rm); the remaining examples copy-and-clean logic is unchanged and correct.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[build.sh starts] --> B["cp -r examples → nemoguardrails/examples"]
    B --> C[poetry build]
    C --> D["rm -rf nemoguardrails/examples"]
    D --> E[Done]

    style A fill:#f0f0f0
    style E fill:#d4edda
Loading

Reviews (3): Last reviewed commit: "fix(build): remove chat-ui references fr..." | Re-trigger Greptile

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

📝 Walkthrough

Walkthrough

The build script removes chat-ui packaging workflow steps previously performed before running poetry build, including source/destination path definitions, directory copying, and cleanup operations. The examples workflow behavior remains unchanged.

Changes

Cohort / File(s) Summary
Build Script Configuration
.github/scripts/build.sh
Removed 4 lines of chat-ui packaging workflow: source/destination path definitions, directory copy operation into nemoguardrails package, and cleanup deletion step. examples packaging logic unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: removing chat-ui references from the build script that were causing workflow failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Results For Major Changes ✅ Passed This PR removes 4 lines from build.sh that referenced a non-existent directory (chat-ui), fixing a failing workflow. It is a straightforward minor bug fix without new features or breaking changes.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/build-script-remove-chat-ui

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread .github/workflows/test-and-build-wheel.yml
@Pouyanpi Pouyanpi force-pushed the fix/build-script-remove-chat-ui branch from 9067913 to 5ff36c8 Compare April 29, 2026 10:43
@Pouyanpi Pouyanpi merged commit 76d3af8 into develop Apr 30, 2026
4 checks passed
@Pouyanpi Pouyanpi deleted the fix/build-script-remove-chat-ui branch April 30, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant