Skip to content

test(recorded): add runtime checks; include tests#2167

Merged
Pouyanpi merged 1 commit into
developfrom
pouyanpi/type-check-recorded-tests
Jul 13, 2026
Merged

test(recorded): add runtime checks; include tests#2167
Pouyanpi merged 1 commit into
developfrom
pouyanpi/type-check-recorded-tests

Conversation

@Pouyanpi

@Pouyanpi Pouyanpi commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

include tests/recorded to static type checks

Summary by CodeRabbit

  • Tests
    • Improved validation of asynchronous generation responses.
    • Added per-chunk type checks for streamed responses.
    • Expanded type-checking coverage to include recorded test files.

@github-actions github-actions Bot added size: XS status: needs triage New issues that have not yet been reviewed or categorized. labels Jul 13, 2026
@Pouyanpi Pouyanpi added status: triaged Triaged by a maintainer; eligible for automated review (CodeRabbit/Greptile). and removed status: needs triage New issues that have not yet been reviewed or categorized. labels Jul 13, 2026
@Pouyanpi Pouyanpi self-assigned this Jul 13, 2026
@greptile-apps

greptile-apps Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR expands recorded-test type checking and tightens test assertions.

  • Adds tests/recorded/** to the static type-check include list.
  • Reuses the validated generation response in one async request test.
  • Checks streamed metadata chunks as dictionaries before collecting them.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
pyproject.toml Adds recorded tests to the configured static type-check include list.
tests/recorded/rails/public_api/test_requests.py Stores the validated generation response before checking logged LLM tasks.
tests/recorded/rails/public_api/test_stream.py Validates each metadata stream chunk before appending it to the collected chunks.

Reviews (2): Last reviewed commit: "test(recorded): add runtime checks; incl..." | Re-trigger Greptile

@Pouyanpi
Pouyanpi force-pushed the pouyanpi/type-check-recorded-tests branch from 17cdcb5 to c20ae81 Compare July 13, 2026 11:33
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f073a5d8-4b82-47de-bc46-fbb0f19fa44d

📥 Commits

Reviewing files that changed from the base of the PR and between 5331054 and 17cdcb5.

📒 Files selected for processing (3)
  • pyproject.toml
  • tests/recorded/rails/public_api/test_requests.py
  • tests/recorded/rails/public_api/test_stream.py

📝 Walkthrough

Walkthrough

The change expands ty analysis to tests/recorded/** and updates recorded public API tests to preserve assertion-helper results and validate streamed chunk types during iteration.

Changes

Recorded test validation

Layer / File(s) Summary
Expand ty test coverage
pyproject.toml
Adds tests/recorded/** to the paths analyzed by ty.
Update recorded API assertions
tests/recorded/rails/public_api/test_requests.py, tests/recorded/rails/public_api/test_stream.py
Reassigns the normalized generation response and checks each streamed chunk is a dictionary during iteration.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the PR's main themes: adding runtime checks to recorded tests and including tests in static type checks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Results For Major Changes ✅ Passed Only small typing/test tweaks across 3 files; this is a minor change, so missing test results in the PR description is acceptable.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pouyanpi/type-check-recorded-tests

Comment @coderabbitai help to get the list of available commands.

@Pouyanpi
Pouyanpi merged commit 451b0a0 into develop Jul 13, 2026
14 checks passed
@Pouyanpi
Pouyanpi deleted the pouyanpi/type-check-recorded-tests branch July 13, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XS status: triaged Triaged by a maintainer; eligible for automated review (CodeRabbit/Greptile).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant