test(recorded): add runtime checks; include tests#2167
Merged
Conversation
Contributor
Greptile SummaryThis PR expands recorded-test type checking and tightens test assertions.
|
| Filename | Overview |
|---|---|
| pyproject.toml | Adds recorded tests to the configured static type-check include list. |
| tests/recorded/rails/public_api/test_requests.py | Stores the validated generation response before checking logged LLM tasks. |
| tests/recorded/rails/public_api/test_stream.py | Validates each metadata stream chunk before appending it to the collected chunks. |
Reviews (2): Last reviewed commit: "test(recorded): add runtime checks; incl..." | Re-trigger Greptile
Pouyanpi
force-pushed
the
pouyanpi/type-check-recorded-tests
branch
from
July 13, 2026 11:33
17cdcb5 to
c20ae81
Compare
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe change expands ChangesRecorded test validation
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
include
tests/recordedto static type checksSummary by CodeRabbit