refactor(agent-registry): address review — drop dead query path, fix tests, clarify gymnasium

Review follow-up:
- Remove the unreachable query filter from gym list agents (cli/agents.py): no QUERY flag is
  registered for the command, so the branch could never run; drop it (and _fuzzy_matches and the
  mock-only test_query_filters that masked it). search stays benchmarks-only.
- test_agent_entry_is_hashable: replace the trivially-true `... or True` assertion with a real
  check on AgentEntry.variants.
- Docstring: stop citing gymnasium as a Pattern A (composable) example — gymnasium-style agents
  ship their own env and classify as self-contained (Pattern B), matching cmunley1s review point.

Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>

Author: wprazuch

nemo_gym/agent_registry.py

@@ -22,13 +22,13 @@
 
 - **References a separate resources server (Pattern A):** the config sets
   ``responses_api_agents.<type>.resources_server``, so the harness is reusable and must be wired to a
-  *compatible* resources server + dataset (e.g. the ``simple_agent`` tool-use pattern, the
-  ``gymnasium`` pattern). Harnesses compose *within* a pattern, not across it; which
-  harness↔resources-server pairings are actually compatible is decided by the config composer's
-  compatibility guard, NOT by this registry.
+  *compatible* resources server + dataset (e.g. the ``simple_agent`` tool-use pattern). Harnesses
+  compose *within* a pattern, not across it; which harness↔resources-server pairings are actually
+  compatible is decided by the config composer's compatibility guard, NOT by this registry.
 - **Self-contained (Pattern B):** the harness bundles its own environment/framework or external LLM
   loop (``agent_framework``; e.g. ``swe_agents``, ``harbor_agent``, ``verifiers_agent``,
-  ``claude_code_agent``) and runs with its own config rather than wired to a separate environment.
+  ``claude_code_agent``, and ``gymnasium``-style agents that ship their own env) and runs with its
+  own config rather than wired to a separate environment.
 
 Discovery only reads config files; it never resolves interpolations or missing values and never
 starts servers, so it is safe to call when secrets/API keys referenced by a config are unset.

nemo_gym/cli/agents.py

@@ -21,17 +21,11 @@
 from nemo_gym.config_types import BaseNeMoGymCLIConfig
 from nemo_gym.global_config import (
     JSON_OUTPUT_KEY_NAME,
-    QUERY_KEY_NAME,
     GlobalConfigDictParserConfig,
     get_global_config_dict,
 )
 
 
-def _fuzzy_matches(query: str, *fields: str) -> bool:
-    needle = query.lower()
-    return any(needle in (field or "").lower() for field in fields)
-
-
 def list_agents() -> None:
     """CLI command: list discovered agent harnesses and how each composes (Pattern A vs B).
 
@@ -49,12 +43,6 @@ def list_agents() -> None:
 
     agents = discover_agents()
 
-    query = global_config_dict.get(QUERY_KEY_NAME)
-    if query:
-        agents = {
-            name: entry for name, entry in agents.items() if _fuzzy_matches(query, name, entry.description or "")
-        }
-
     if global_config_dict.get(JSON_OUTPUT_KEY_NAME, False):
         payload = [
             {
@@ -70,7 +58,7 @@ def list_agents() -> None:
         return
 
     if not agents:
-        rich.print("No agents found." if not query else f"No agents match {query!r}.")
+        rich.print("No agents found.")
         return
 
     table = Table(title="NeMo Gym agents")

tests/unit_tests/test_agent_registry.py

@@ -17,7 +17,6 @@
 from pytest import raises
 
 from nemo_gym.agent_registry import (
-    AGENTS_DIR,
     AgentEntry,
     AgentNotComposableError,
     AgentNotFoundError,
@@ -223,4 +222,4 @@ def test_discovers_real_simple_agent_as_composable(self) -> None:
     def test_agent_entry_is_hashable(self) -> None:
         entry = AgentEntry(name="a", path=Path("a"), config_paths=(Path("a/configs/a.yaml"),), self_contained=True)
         assert {entry: 1}[entry] == 1
-        assert entry.path == AGENTS_DIR / "a" or True  # AGENTS_DIR import exercised
+        assert entry.variants == {"a": Path("a/configs/a.yaml")}

tests/unit_tests/test_cli_agents.py

@@ -75,12 +75,3 @@ def test_json_output(self, capsys) -> None:
         assert by_name["simple_agent"]["pattern"] == "A (composable)"
         assert by_name["swe_agents"]["self_contained"] is True
         assert by_name["swe_agents"]["variants"] == ["swebench_openhands"]
-
-    def test_query_filters(self, capsys) -> None:
-        with (
-            patch("nemo_gym.cli.agents.get_global_config_dict", return_value=_mock_global_config({"query": "swe"})),
-            patch("nemo_gym.cli.agents.discover_agents", return_value=_AGENTS),
-        ):
-            list_agents()
-        out = capsys.readouterr().out
-        assert "swe_agents" in out and "simple_agent" not in out